| Message ID | 20210704134325.24842-1-pali@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | powerpc/fsl/dts: Fix phy-connection-type for fm1mac3 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote: > Property phy-connection-type contains invalid value "sgmii-2500" per scheme > defined in file ethernet-controller.yaml. > > Correct phy-connection-type value should be "2500base-x". > > Signed-off-by: Pali Rohár <pali@kernel.org> > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the > board device tree(s)") > --- > arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > index 5ba6fbfca274..f82f85c65964 100644 > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > @@ -154,7 +154,7 @@ > > fm1mac3: ethernet@e4000 { > phy-handle = <&sgmii_aqr_phy3>; > - phy-connection-type = "sgmii-2500"; > + phy-connection-type = "2500base-x"; > sleep = <&rcpm 0x20000000>; > }; > Acked-by: Scott Wood <oss@buserror.net> -Scott
On Wednesday 14 July 2021 12:11:49 Scott Wood wrote: > On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote: > > Property phy-connection-type contains invalid value "sgmii-2500" per scheme > > defined in file ethernet-controller.yaml. > > > > Correct phy-connection-type value should be "2500base-x". > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the > > board device tree(s)") > > --- > > arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > index 5ba6fbfca274..f82f85c65964 100644 > > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > @@ -154,7 +154,7 @@ > > > > fm1mac3: ethernet@e4000 { > > phy-handle = <&sgmii_aqr_phy3>; > > - phy-connection-type = "sgmii-2500"; > > + phy-connection-type = "2500base-x"; > > sleep = <&rcpm 0x20000000>; > > }; > > > > Acked-by: Scott Wood <oss@buserror.net> > > -Scott Hello! If there is not any objection, could you take this patch?
On Friday 27 August 2021 13:38:36 Pali Rohár wrote: > On Wednesday 14 July 2021 12:11:49 Scott Wood wrote: > > On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote: > > > Property phy-connection-type contains invalid value "sgmii-2500" per scheme > > > defined in file ethernet-controller.yaml. > > > > > > Correct phy-connection-type value should be "2500base-x". > > > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the > > > board device tree(s)") > > > --- > > > arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > index 5ba6fbfca274..f82f85c65964 100644 > > > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > @@ -154,7 +154,7 @@ > > > > > > fm1mac3: ethernet@e4000 { > > > phy-handle = <&sgmii_aqr_phy3>; > > > - phy-connection-type = "sgmii-2500"; > > > + phy-connection-type = "2500base-x"; > > > sleep = <&rcpm 0x20000000>; > > > }; > > > > > > > Acked-by: Scott Wood <oss@buserror.net> > > > > -Scott > > Hello! If there is not any objection, could you take this patch? Hello! I would like to remind this patch.
On Tue, Sep 28, 2021 at 11:39:18PM +0200, Pali Rohár wrote: > On Friday 27 August 2021 13:38:36 Pali Rohár wrote: > > On Wednesday 14 July 2021 12:11:49 Scott Wood wrote: > > > On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote: > > > > Property phy-connection-type contains invalid value "sgmii-2500" per scheme > > > > defined in file ethernet-controller.yaml. > > > > > > > > Correct phy-connection-type value should be "2500base-x". > > > > > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > > > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the > > > > board device tree(s)") > > > > --- > > > > arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > index 5ba6fbfca274..f82f85c65964 100644 > > > > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > @@ -154,7 +154,7 @@ > > > > > > > > fm1mac3: ethernet@e4000 { > > > > phy-handle = <&sgmii_aqr_phy3>; > > > > - phy-connection-type = "sgmii-2500"; > > > > + phy-connection-type = "2500base-x"; > > > > sleep = <&rcpm 0x20000000>; > > > > }; > > > > > > > > > > Acked-by: Scott Wood <oss@buserror.net> > > > > > > -Scott > > > > Hello! If there is not any objection, could you take this patch? > > Hello! I would like to remind this patch. Hi Pali I suggest you resend, and with To: Michael Ellerman <mpe@ellerman.id.au> to make it clear who you expect to pick up the patch. Michael seems to do the Maintainer work in arch/powerpc/boot/dts/ Andrew
On Wednesday 29 September 2021 16:25:01 Andrew Lunn wrote: > On Tue, Sep 28, 2021 at 11:39:18PM +0200, Pali Rohár wrote: > > On Friday 27 August 2021 13:38:36 Pali Rohár wrote: > > > On Wednesday 14 July 2021 12:11:49 Scott Wood wrote: > > > > On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote: > > > > > Property phy-connection-type contains invalid value "sgmii-2500" per scheme > > > > > defined in file ethernet-controller.yaml. > > > > > > > > > > Correct phy-connection-type value should be "2500base-x". > > > > > > > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > > > > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the > > > > > board device tree(s)") > > > > > --- > > > > > arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > > index 5ba6fbfca274..f82f85c65964 100644 > > > > > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts > > > > > @@ -154,7 +154,7 @@ > > > > > > > > > > fm1mac3: ethernet@e4000 { > > > > > phy-handle = <&sgmii_aqr_phy3>; > > > > > - phy-connection-type = "sgmii-2500"; > > > > > + phy-connection-type = "2500base-x"; > > > > > sleep = <&rcpm 0x20000000>; > > > > > }; > > > > > > > > > > > > > Acked-by: Scott Wood <oss@buserror.net> > > > > > > > > -Scott > > > > > > Hello! If there is not any objection, could you take this patch? > > > > Hello! I would like to remind this patch. > > Hi Pali > > I suggest you resend, and with To: Michael Ellerman <mpe@ellerman.id.au> > to make it clear who you expect to pick up the > patch. Michael seems to do the Maintainer work in > arch/powerpc/boot/dts/ > > Andrew Done: https://lore.kernel.org/lkml/20211002090409.3833-1-pali@kernel.org/T/#u
diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts b/arch/powerpc/boot/dts/fsl/t1023rdb.dts index 5ba6fbfca274..f82f85c65964 100644 --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts @@ -154,7 +154,7 @@ fm1mac3: ethernet@e4000 { phy-handle = <&sgmii_aqr_phy3>; - phy-connection-type = "sgmii-2500"; + phy-connection-type = "2500base-x"; sleep = <&rcpm 0x20000000>; };
Property phy-connection-type contains invalid value "sgmii-2500" per scheme defined in file ethernet-controller.yaml. Correct phy-connection-type value should be "2500base-x". Signed-off-by: Pali Rohár <pali@kernel.org> Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the board device tree(s)") --- arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)