diff mbox series

ksmbd: fix documentation for 2 functions

Message ID 20210928225634.28432-1-ematsumiya@suse.de (mailing list archive)
State New, archived
Headers show
Series ksmbd: fix documentation for 2 functions | expand

Commit Message

Enzo Matsumiya Sept. 28, 2021, 10:56 p.m. UTC
ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
task_struct/ERR_PTR.

Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
---
 fs/ksmbd/transport_tcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Namjae Jeon Sept. 29, 2021, 12:08 a.m. UTC | #1
2021-09-29 7:56 GMT+09:00, Enzo Matsumiya <ematsumiya@suse.de>:
> ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
> task_struct/ERR_PTR.
>
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>

Thanks for your patch!
Steve French Sept. 29, 2021, 3:54 a.m. UTC | #2
merged into cifsd-for-next

On Tue, Sep 28, 2021 at 7:10 PM Namjae Jeon <linkinjeon@kernel.org> wrote:
>
> 2021-09-29 7:56 GMT+09:00, Enzo Matsumiya <ematsumiya@suse.de>:
> > ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
> > task_struct/ERR_PTR.
> >
> > Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> Acked-by: Namjae Jeon <linkinjeon@kernel.org>
>
> Thanks for your patch!
diff mbox series

Patch

diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c
index dc15a5ecd2e0..c14320e03b69 100644
--- a/fs/ksmbd/transport_tcp.c
+++ b/fs/ksmbd/transport_tcp.c
@@ -215,7 +215,7 @@  static int ksmbd_tcp_new_connection(struct socket *client_sk)
  * ksmbd_kthread_fn() - listen to new SMB connections and callback server
  * @p:		arguments to forker thread
  *
- * Return:	Returns a task_struct or ERR_PTR
+ * Return:	0 on success, error number otherwise
  */
 static int ksmbd_kthread_fn(void *p)
 {
@@ -387,7 +387,7 @@  static void tcp_destroy_socket(struct socket *ksmbd_socket)
 /**
  * create_socket - create socket for ksmbd/0
  *
- * Return:	Returns a task_struct or ERR_PTR
+ * Return:	0 on success, error number otherwise
  */
 static int create_socket(struct interface *iface)
 {