mbox series

[v2,0/3] Cleanup MAY_HAVE_SPARSE_IRQ

Message ID 20210929023522.57732-1-wangkefeng.wang@huawei.com (mailing list archive)
Headers show
Series Cleanup MAY_HAVE_SPARSE_IRQ | expand

Message

Kefeng Wang Sept. 29, 2021, 2:35 a.m. UTC
Most ARCHs support SPARSE_IRQ, the dynamical and statical irq
description allocation are alternative.

The last user of MAY_HAVE_SPARSE_IRQ is sh/csky, but the sh use
SPARSE_IRQ, MAY_HAVE_SPARSE_IRQ could be kill. and for csky, it
uses statical allocation by default. 

So MAY_HAVE_SPARSE_IRQ seems to be useless, no need to maintain a
separate MAY_HAVE_SPARSE_IRQ config, kill it.

Also cleanup the kernel/irq/Kconfig a little.

v2: 
- drop all the NR_IRQS suggested by Geert
- don' use SPARSE_IRQ for csky by default, suggested by Guo.

Kefeng Wang (3):
  sh: Cleanup about SPARSE_IRQ
  csky: Kill MAY_HAVE_SPARSE_IRQ
  genirq: Cleanup Kconfig

 arch/csky/Kconfig         |  1 -
 arch/sh/Kconfig           |  1 -
 arch/sh/include/asm/irq.h | 11 ---------
 kernel/irq/Kconfig        | 50 ++++++++++++++++-----------------------
 4 files changed, 20 insertions(+), 43 deletions(-)

Comments

Geert Uytterhoeven Sept. 29, 2021, 7:21 a.m. UTC | #1
Hi Kefeng,

On Wed, Sep 29, 2021 at 4:35 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> Most ARCHs support SPARSE_IRQ, the dynamical and statical irq
> description allocation are alternative.
>
> The last user of MAY_HAVE_SPARSE_IRQ is sh/csky, but the sh use
> SPARSE_IRQ, MAY_HAVE_SPARSE_IRQ could be kill. and for csky, it
> uses statical allocation by default.
>
> So MAY_HAVE_SPARSE_IRQ seems to be useless, no need to maintain a
> separate MAY_HAVE_SPARSE_IRQ config, kill it.
>
> Also cleanup the kernel/irq/Kconfig a little.
>
> v2:
> - drop all the NR_IRQS suggested by Geert
> - don' use SPARSE_IRQ for csky by default, suggested by Guo.
>
> Kefeng Wang (3):
>   sh: Cleanup about SPARSE_IRQ
>   csky: Kill MAY_HAVE_SPARSE_IRQ
>   genirq: Cleanup Kconfig

Thanks for the update!

Tested on SH on landisk (real) and rts7751r2d (qemu), so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

P.S. Please use the same version number in all patches of the series,
     to avoid confusing tools like b4.

https://lore.kernel.org/all/20210929023522.57732-1-wangkefeng.wang@huawei.com/
2021-09-29  2:35 ` [PATCH v1 1/3] sh: Cleanup about SPARSE_IRQ Kefeng Wang
2021-09-29  2:35 ` [PATCH v2 2/3] csky: Kill MAY_HAVE_SPARSE_IRQ Kefeng Wang
2021-09-29  2:35 ` [PATCH v3 3/3] genirq: Cleanup Kconfig Kefeng Wang
                          ^^

Gr{oetje,eeting}s,

                        Geert
Kefeng Wang Sept. 29, 2021, 8:12 a.m. UTC | #2
On 2021/9/29 15:21, Geert Uytterhoeven wrote:
> Hi Kefeng,
> 
> On Wed, Sep 29, 2021 at 4:35 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> Most ARCHs support SPARSE_IRQ, the dynamical and statical irq
>> description allocation are alternative.
>>
>> The last user of MAY_HAVE_SPARSE_IRQ is sh/csky, but the sh use
>> SPARSE_IRQ, MAY_HAVE_SPARSE_IRQ could be kill. and for csky, it
>> uses statical allocation by default.
>>
>> So MAY_HAVE_SPARSE_IRQ seems to be useless, no need to maintain a
>> separate MAY_HAVE_SPARSE_IRQ config, kill it.
>>
>> Also cleanup the kernel/irq/Kconfig a little.
>>
>> v2:
>> - drop all the NR_IRQS suggested by Geert
>> - don' use SPARSE_IRQ for csky by default, suggested by Guo.
>>
>> Kefeng Wang (3):
>>    sh: Cleanup about SPARSE_IRQ
>>    csky: Kill MAY_HAVE_SPARSE_IRQ
>>    genirq: Cleanup Kconfig
> 
> Thanks for the update!
> 
> Tested on SH on landisk (real) and rts7751r2d (qemu), so
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for your test.
> 
> P.S. Please use the same version number in all patches of the series,
>       to avoid confusing tools like b4.
> 
> https://lore.kernel.org/all/20210929023522.57732-1-wangkefeng.wang@huawei.com/
> 2021-09-29  2:35 ` [PATCH v1 1/3] sh: Cleanup about SPARSE_IRQ Kefeng Wang
> 2021-09-29  2:35 ` [PATCH v2 2/3] csky: Kill MAY_HAVE_SPARSE_IRQ Kefeng Wang
> 2021-09-29  2:35 ` [PATCH v3 3/3] genirq: Cleanup Kconfig Kefeng Wang
>                            ^^
> 
Strange, maybe some unexpected change in my local dir... sorry for the 
confusing.

> Gr{oetje,eeting}s,
> 
>                          Geert
>
Kefeng Wang Oct. 19, 2021, 12:30 p.m. UTC | #3
Hi Thomas, Could you pickup this cleanup patchset from your tree if 
possible, thanks.

On 2021/9/29 10:35, Kefeng Wang wrote:
> Most ARCHs support SPARSE_IRQ, the dynamical and statical irq
> description allocation are alternative.
> 
> The last user of MAY_HAVE_SPARSE_IRQ is sh/csky, but the sh use
> SPARSE_IRQ, MAY_HAVE_SPARSE_IRQ could be kill. and for csky, it
> uses statical allocation by default.
> 
> So MAY_HAVE_SPARSE_IRQ seems to be useless, no need to maintain a
> separate MAY_HAVE_SPARSE_IRQ config, kill it.
> 
> Also cleanup the kernel/irq/Kconfig a little.
> 
> v2:
> - drop all the NR_IRQS suggested by Geert
> - don' use SPARSE_IRQ for csky by default, suggested by Guo.
> 
> Kefeng Wang (3):
>    sh: Cleanup about SPARSE_IRQ
>    csky: Kill MAY_HAVE_SPARSE_IRQ
>    genirq: Cleanup Kconfig
> 
>   arch/csky/Kconfig         |  1 -
>   arch/sh/Kconfig           |  1 -
>   arch/sh/include/asm/irq.h | 11 ---------
>   kernel/irq/Kconfig        | 50 ++++++++++++++++-----------------------
>   4 files changed, 20 insertions(+), 43 deletions(-)
>