| Message ID | 20210929061403.8587-1-magnus.karlsson@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3103836496e75095ac208cc180a9fe8f7ff33fd8 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] xsk: fix clang build error in __xp_alloc | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 11 maintainers not CCed: andrii@kernel.org hawk@kernel.org kuba@kernel.org kpsingh@kernel.org kafai@fb.com llvm@lists.linux.dev john.fastabend@gmail.com davem@davemloft.net ndesaulniers@google.com songliubraving@fb.com yhs@fb.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
| bpf/vmtest-bpf-next | success | VM_Test |
| bpf/vmtest-bpf-next-PR | success | PR summary |
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 29 Sep 2021 08:14:03 +0200 you wrote: > From: Magnus Karlsson <magnus.karlsson@intel.com> > > Fix a build error with clang in __xp_alloc(). > > net/xdp/xsk_buff_pool.c:465:15: error: variable 'xskb' is uninitialized > when used here [-Werror,-Wuninitialized] > xp_release(xskb); > ^~~~ > > [...] Here is the summary with links: - [bpf-next] xsk: fix clang build error in __xp_alloc https://git.kernel.org/bpf/bpf-next/c/3103836496e7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On Wed, Sep 29, 2021 at 08:14:03AM +0200, Magnus Karlsson wrote: > From: Magnus Karlsson <magnus.karlsson@intel.com> > > Fix a build error with clang in __xp_alloc(). > > net/xdp/xsk_buff_pool.c:465:15: error: variable 'xskb' is uninitialized > when used here [-Werror,-Wuninitialized] > xp_release(xskb); > ^~~~ > > This is correctly detected by clang, but not gcc. In fact, the > xp_release() statement should not be there at all in the refactored > code, so just remove it. Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> > > Fixes: 94033cd8e73b ("xsk: Optimize for aligned case") > Reported-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> > --- > net/xdp/xsk_buff_pool.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c > index 96b14e51ba7e..90c4e1e819d3 100644 > --- a/net/xdp/xsk_buff_pool.c > +++ b/net/xdp/xsk_buff_pool.c > @@ -462,7 +462,6 @@ static struct xdp_buff_xsk *__xp_alloc(struct xsk_buff_pool *pool) > for (;;) { > if (!xskq_cons_peek_addr_unchecked(pool->fq, &addr)) { > pool->fq->queue_empty_descs++; > - xp_release(xskb); > return NULL; > } > > > base-commit: 72e1781a5de9e3ee804e24f7ce9a7dd85596fc51 > -- > 2.29.0 >
diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c index 96b14e51ba7e..90c4e1e819d3 100644 --- a/net/xdp/xsk_buff_pool.c +++ b/net/xdp/xsk_buff_pool.c @@ -462,7 +462,6 @@ static struct xdp_buff_xsk *__xp_alloc(struct xsk_buff_pool *pool) for (;;) { if (!xskq_cons_peek_addr_unchecked(pool->fq, &addr)) { pool->fq->queue_empty_descs++; - xp_release(xskb); return NULL; }