| Message ID | 20210929094425.745-2-granquet@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Mediatek MT8195 HDMI Tx support | expand |
On Wed, 29 Sep 2021 11:44:22 +0200, Guillaume Ranquet wrote: > Add bindings to describe Mediatek MT8195 HDMI PHY > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > --- > .../phy/mediatek,mtk8195-hdmi-phy.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml: properties:compatible: [{'const': 'mediatek,mt8195-hdmi-phy'}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# ./Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/phy/mediatek,mtk8195-hdmi-phy.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml: ignoring, error in schema: properties: compatible warning: no schema found in file: ./Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.example.dt.yaml: example-0: hdmi-phy@11d5f000:reg:0: [0, 299233280, 0, 256] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.example.dt.yaml:0:0: /example-0/hdmi-phy@11d5f000: failed to match any schema with compatible: ['mediatek,mt8195-hdmi-phy'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1534286 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Wed, 2021-09-29 at 11:44 +0200, Guillaume Ranquet wrote: > Add bindings to describe Mediatek MT8195 HDMI PHY > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > --- > .../phy/mediatek,mtk8195-hdmi-phy.yaml | 70 > +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,mtk8195- > hdmi-phy.yaml > b/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi- > phy.yaml > new file mode 100644 > index 0000000000000..6b39bb8c9dfe7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi- > phy.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 MediaTek > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/mediatek,hdmi-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek High Definition Multimedia Interface (HDMI) PHY > binding for mt8195 > + > +maintainers: > + - Chun-Kuang Hu <chunkuang.hu@kernel.org> > + - Philipp Zabel <p.zabel@pengutronix.de> > + - Chunfeng Yun <chunfeng.yun@mediatek.com> > + > +description: | > + The HDMI PHY serializes the HDMI encoder's three channel 10-bit > parallel > + output and drives the HDMI pads. > + > +properties: > + $nodename: > + pattern: "^hdmi-phy@[0-9a-f]+$" > + > + compatible: > + - const: mediatek,mt8195-hdmi-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: PLL reference clock > + > + clock-names: > + items: > + - const: hdmi_xtal_sel No need prefix "hdmi_", After you merge mt8195-hdmi-phy driver into phy-mtk-hdmi.c, this binding will also be merged into mediatek,hdmi-phy.yaml as suggested by Chun-Kuang. Thanks a lot > + > + clock-output-names: > + items: > + - const: hdmi_txpll > + > + "#phy-cells": > + const: 0 > + > + "#clock-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - clock-output-names > + - "#phy-cells" > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + - | > + hdmi_phy: hdmi-phy@11d5f000 { > + compatible = "mediatek,mt8195-hdmi-phy"; > + reg = <0 0x11d5f000 0 0x100>; > + clocks = <&topckgen 77>; > + clock-names = "hdmi_xtal_sel"; > + clock-output-names = "hdmi_txpll"; > + #clock-cells = <0>; > + #phy-cells = <0>; > + }; > + > +...
diff --git a/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml new file mode 100644 index 0000000000000..6b39bb8c9dfe7 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2020 MediaTek +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/mediatek,hdmi-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek High Definition Multimedia Interface (HDMI) PHY binding for mt8195 + +maintainers: + - Chun-Kuang Hu <chunkuang.hu@kernel.org> + - Philipp Zabel <p.zabel@pengutronix.de> + - Chunfeng Yun <chunfeng.yun@mediatek.com> + +description: | + The HDMI PHY serializes the HDMI encoder's three channel 10-bit parallel + output and drives the HDMI pads. + +properties: + $nodename: + pattern: "^hdmi-phy@[0-9a-f]+$" + + compatible: + - const: mediatek,mt8195-hdmi-phy + + reg: + maxItems: 1 + + clocks: + items: + - description: PLL reference clock + + clock-names: + items: + - const: hdmi_xtal_sel + + clock-output-names: + items: + - const: hdmi_txpll + + "#phy-cells": + const: 0 + + "#clock-cells": + const: 0 + +required: + - compatible + - reg + - clocks + - clock-names + - clock-output-names + - "#phy-cells" + - "#clock-cells" + +additionalProperties: false + +examples: + - | + hdmi_phy: hdmi-phy@11d5f000 { + compatible = "mediatek,mt8195-hdmi-phy"; + reg = <0 0x11d5f000 0 0x100>; + clocks = <&topckgen 77>; + clock-names = "hdmi_xtal_sel"; + clock-output-names = "hdmi_txpll"; + #clock-cells = <0>; + #phy-cells = <0>; + }; + +...
Add bindings to describe Mediatek MT8195 HDMI PHY Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> --- .../phy/mediatek,mtk8195-hdmi-phy.yaml | 70 +++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mtk8195-hdmi-phy.yaml