diff mbox series

clocksource/drivers/timer-ti-dm: Select TIMER_OF

Message ID 20210828175747.3777891-1-keescook@chromium.org (mailing list archive)
State New, archived
Headers show
Series clocksource/drivers/timer-ti-dm: Select TIMER_OF | expand

Commit Message

Kees Cook Aug. 28, 2021, 5:57 p.m. UTC
When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:

arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@intel.com/
Cc: Tony Lindgren <tony@atomide.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Keerthy <j-keerthy@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Ladislav Michl <ladis@linux-mips.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap@vger.kernel.org
Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Tony Lindgren Sept. 30, 2021, 8:49 a.m. UTC | #1
* Kees Cook <keescook@chromium.org> [210828 17:58]:
> When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
> due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
> CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
> 
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@intel.com/
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> Cc: Ladislav Michl <ladis@linux-mips.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: linux-omap@vger.kernel.org
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Kees Cook <keescook@chromium.org>

Sorry for the delay, I just noticed I never replied earlier:

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/clocksource/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..08f8cb944a2a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -24,6 +24,7 @@ config I8253_LOCK
>  
>  config OMAP_DM_TIMER
>  	bool
> +	select TIMER_OF
>  
>  config CLKBLD_I8253
>  	def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
> -- 
> 2.30.2
>
diff mbox series

Patch

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 0f5e3983951a..08f8cb944a2a 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -24,6 +24,7 @@  config I8253_LOCK
 
 config OMAP_DM_TIMER
 	bool
+	select TIMER_OF
 
 config CLKBLD_I8253
 	def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK