[v3,09/16] ASoC: add Rich Graph Card Yaml Document

Commit Message

Kuninori Morimoto Sept. 10, 2021, 1:22 a.m. UTC

From: Kuninori Morimoto <[e-mail]>

This patch adds Rich Graph Card Yaml Document to Linux.

Signed-off-by: Kuninori Morimoto <[e-mail]>
---
 .../bindings/sound/rich-graph-card.yaml       | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/rich-graph-card.yaml

Comments

Mark Brown Oct. 1, 2021, 9:06 p.m. UTC | #1

On Fri, Sep 10, 2021 at 10:22:39AM +0900, Kuninori Morimoto wrote:

> +  multi:
> +    description: Multi-CPU/Codec node
> +  dpcm:
> +    description: DPCM node
> +  codec2codec:
> +    description: Codec to Codec node

I think I need to have another look through this sometime next week but
other than the naming thing discussed in the other subthread I think the
only issues I see at a high level are the standard concern about putting
DPCM into an ABI which I think we're stuck with having to do right now,
and also if we can merge multi and CODEC-CODEC links more.  There's bits
you've called out in your changelog as needing further work but I think
it's OK to add things incrementally.

Overall it's looking pretty good, thanks for working on this.

Kuninori Morimoto Oct. 4, 2021, 1:50 a.m. UTC | #2

Hi Mark

Thank you for your reply

> > +  multi:
> > +    description: Multi-CPU/Codec node
> > +  dpcm:
> > +    description: DPCM node
> > +  codec2codec:
> > +    description: Codec to Codec node
> 
> I think I need to have another look through this sometime next week but
> other than the naming thing discussed in the other subthread I think the
> only issues I see at a high level are the standard concern about putting
> DPCM into an ABI which I think we're stuck with having to do right now,
> and also if we can merge multi and CODEC-CODEC links more.  There's bits
> you've called out in your changelog as needing further work but I think
> it's OK to add things incrementally.
> 
> Overall it's looking pretty good, thanks for working on this.

Thank you.
I'm looking forward to your detail review,
and happy to create v4

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Mark Brown Oct. 5, 2021, 5:26 p.m. UTC | #3

On Mon, Oct 04, 2021 at 10:50:44AM +0900, Kuninori Morimoto wrote:

> I'm looking forward to your detail review,
> and happy to create v4

Please just go ahead and send v4, I don't think I've got anything
really.

Patch

diff --git a/Documentation/devicetree/bindings/sound/rich-graph-card.yaml b/Documentation/devicetree/bindings/sound/rich-graph-card.yaml
new file mode 100644
index 000000000000..f998c50da8f7
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/rich-graph-card.yaml
@@ -0,0 +1,57 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/rich-graph-card.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rich Graph Card Device Tree Bindings
+
+maintainers:
+  - Kuninori Morimoto <[e-mail]>
+
+properties:
+  compatible:
+    enum:
+      - rich-graph-card
+  links:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+  label:
+    maxItems: 1
+  routing:
+    description: |
+      A list of the connections between audio components.
+      Each entry is a pair of strings, the first being the
+      connection's sink, the second being the connection's source.
+    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
+  multi:
+    description: Multi-CPU/Codec node
+  dpcm:
+    description: DPCM node
+  codec2codec:
+    description: Codec to Codec node
+
+required:
+  - compatible
+  - links
+
+additionalProperties: false
+
+examples:
+  - |
+    sound {
+        compatible = "rich-graph-card";
+
+        links = <&cpu_port>;
+    };
+
+    cpu {
+        compatible = "cpu-driver";
+
+        cpu_port: port { cpu_ep: endpoint { remote-endpoint = <&codec_ep>; }; };
+    };
+
+    codec {
+        compatible = "codec-driver";
+
+        port { codec_ep: endpoint { remote-endpoint = <&cpu_ep>; }; };
+    };