| Message ID | 20210910234047.1019925-6-ndesaulniers@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote: > The minimum supported version of GCC is now 5.1. The check wasn't > correct as written anyways since GCC_VERSION is 0 when CC=clang. > > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Indeed, I meant to clean this up a while ago but forgot :/ Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > arch/riscv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index c79955655fa4..5fc1d0cc82e1 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -235,7 +235,7 @@ config ARCH_RV32I > config ARCH_RV64I > bool "RV64I" > select 64BIT > - select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000 > + select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 > select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8) > select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE > select HAVE_FTRACE_MCOUNT_RECORD if !XIP_KERNEL > -- > 2.33.0.309.g3052b89438-goog > >
On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote: > The minimum supported version of GCC is now 5.1. The check wasn't > correct as written anyways since GCC_VERSION is 0 when CC=clang. > > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Yeah, good catch for Clang too. Reviewed-by: Kees Cook <keescook@chromium.org>
On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote: > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote: >> The minimum supported version of GCC is now 5.1. The check wasn't >> correct as written anyways since GCC_VERSION is 0 when CC=clang. >> >> Cc: Paul Walmsley <paul.walmsley@sifive.com> >> Cc: Palmer Dabbelt <palmer@dabbelt.com> >> Cc: Albert Ou <aou@eecs.berkeley.edu> >> Cc: linux-riscv@lists.infradead.org >> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > Yeah, good catch for Clang too. > > Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> Only this patch ended up in my inbox. Where you guys planning on keeping this whole series together, or did you want me to pick this for the RISC-V tree?
On Mon, Oct 04, 2021 at 05:40:42PM -0700, Palmer Dabbelt wrote: > On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote: > > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote: > > > The minimum supported version of GCC is now 5.1. The check wasn't > > > correct as written anyways since GCC_VERSION is 0 when CC=clang. > > > > > > Cc: Paul Walmsley <paul.walmsley@sifive.com> > > > Cc: Palmer Dabbelt <palmer@dabbelt.com> > > > Cc: Albert Ou <aou@eecs.berkeley.edu> > > > Cc: linux-riscv@lists.infradead.org > > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > > > Yeah, good catch for Clang too. > > > > Reviewed-by: Kees Cook <keescook@chromium.org> > > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> > > Only this patch ended up in my inbox. Where you guys planning on keeping > this whole series together, or did you want me to pick this for the RISC-V > tree? Linus already merged this series (see d20758951f8f28c0ee1b2a8a6bb8189858083895)
On Mon, 04 Oct 2021 17:50:46 PDT (-0700), keescook@chromium.org wrote: > On Mon, Oct 04, 2021 at 05:40:42PM -0700, Palmer Dabbelt wrote: >> On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote: >> > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote: >> > > The minimum supported version of GCC is now 5.1. The check wasn't >> > > correct as written anyways since GCC_VERSION is 0 when CC=clang. >> > > >> > > Cc: Paul Walmsley <paul.walmsley@sifive.com> >> > > Cc: Palmer Dabbelt <palmer@dabbelt.com> >> > > Cc: Albert Ou <aou@eecs.berkeley.edu> >> > > Cc: linux-riscv@lists.infradead.org >> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> >> > >> > Yeah, good catch for Clang too. >> > >> > Reviewed-by: Kees Cook <keescook@chromium.org> >> >> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> >> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> >> >> Only this patch ended up in my inbox. Where you guys planning on keeping >> this whole series together, or did you want me to pick this for the RISC-V >> tree? > > Linus already merged this series (see d20758951f8f28c0ee1b2a8a6bb8189858083895) Thanks.
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index c79955655fa4..5fc1d0cc82e1 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -235,7 +235,7 @@ config ARCH_RV32I config ARCH_RV64I bool "RV64I" select 64BIT - select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000 + select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8) select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE select HAVE_FTRACE_MCOUNT_RECORD if !XIP_KERNEL
The minimum supported version of GCC is now 5.1. The check wasn't correct as written anyways since GCC_VERSION is 0 when CC=clang. Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: linux-riscv@lists.infradead.org Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/riscv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)