diff mbox series

[2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct

Message ID 20210930155633.2745201-3-frieder@fris.de (mailing list archive)
State New, archived
Headers show
Series Devicetree fixes and additions for Kontron SL/BL i.MX8MM boards | expand

Commit Message

Frieder Schrempf Sept. 30, 2021, 3:56 p.m. UTC 
From: Frieder Schrempf <frieder.schrempf@kontron.de>

VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
should be 950 mV for DDR clock frequencies of 1.5 GHz.

This information is taken from the datasheet and the uboot-imx code.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Frieder Schrempf Sept. 30, 2021, 4:02 p.m. UTC | #1 
On 30.09.21 17:56, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
> should be 950 mV for DDR clock frequencies of 1.5 GHz.
> 
> This information is taken from the datasheet and the uboot-imx code.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>

This should also have:

Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and
baseboards")
Cc: stable@vger.kernel.org

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> index 03b3516abd64..b12fb7ce6686 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> @@ -92,10 +92,12 @@ regulators {
>  			reg_vdd_soc: BUCK1 {
>  				regulator-name = "buck1";
>  				regulator-min-microvolt = <800000>;
> -				regulator-max-microvolt = <900000>;
> +				regulator-max-microvolt = <850000>;
>  				regulator-boot-on;
>  				regulator-always-on;
>  				regulator-ramp-delay = <3125>;
> +				nxp,dvs-run-voltage = <850000>;
> +				nxp,dvs-standby-voltage = <800000>;
>  			};
>  
>  			reg_vdd_arm: BUCK2 {
> @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 {
>  			reg_vdd_dram: BUCK3 {
>  				regulator-name = "buck3";
>  				regulator-min-microvolt = <850000>;
> -				regulator-max-microvolt = <900000>;
> +				regulator-max-microvolt = <950000>;
>  				regulator-boot-on;
>  				regulator-always-on;
>  			};
>
Shawn Guo Oct. 5, 2021, 6:49 a.m. UTC | #2 
On Thu, Sep 30, 2021 at 06:02:01PM +0200, Frieder Schrempf wrote:
> On 30.09.21 17:56, Frieder Schrempf wrote:
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> > 
> > VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
> > should be 950 mV for DDR clock frequencies of 1.5 GHz.
> > 
> > This information is taken from the datasheet and the uboot-imx code.
> > 
> > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> This should also have:
> 
> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and
> baseboards")

$ git log 21c4f45b335f
fatal: ambiguous argument '21c4f45b335f': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Shawn

> Cc: stable@vger.kernel.org
> 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> > index 03b3516abd64..b12fb7ce6686 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> > @@ -92,10 +92,12 @@ regulators {
> >  			reg_vdd_soc: BUCK1 {
> >  				regulator-name = "buck1";
> >  				regulator-min-microvolt = <800000>;
> > -				regulator-max-microvolt = <900000>;
> > +				regulator-max-microvolt = <850000>;
> >  				regulator-boot-on;
> >  				regulator-always-on;
> >  				regulator-ramp-delay = <3125>;
> > +				nxp,dvs-run-voltage = <850000>;
> > +				nxp,dvs-standby-voltage = <800000>;
> >  			};
> >  
> >  			reg_vdd_arm: BUCK2 {
> > @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 {
> >  			reg_vdd_dram: BUCK3 {
> >  				regulator-name = "buck3";
> >  				regulator-min-microvolt = <850000>;
> > -				regulator-max-microvolt = <900000>;
> > +				regulator-max-microvolt = <950000>;
> >  				regulator-boot-on;
> >  				regulator-always-on;
> >  			};
> >
Shawn Guo Oct. 5, 2021, 6:53 a.m. UTC | #3 
On Thu, Sep 30, 2021 at 05:56:25PM +0200, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
> should be 950 mV for DDR clock frequencies of 1.5 GHz.
> 
> This information is taken from the datasheet and the uboot-imx code.

I'm wondering where the existing settings were coming from?

Shawn

> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> index 03b3516abd64..b12fb7ce6686 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> @@ -92,10 +92,12 @@ regulators {
>  			reg_vdd_soc: BUCK1 {
>  				regulator-name = "buck1";
>  				regulator-min-microvolt = <800000>;
> -				regulator-max-microvolt = <900000>;
> +				regulator-max-microvolt = <850000>;
>  				regulator-boot-on;
>  				regulator-always-on;
>  				regulator-ramp-delay = <3125>;
> +				nxp,dvs-run-voltage = <850000>;
> +				nxp,dvs-standby-voltage = <800000>;
>  			};
>  
>  			reg_vdd_arm: BUCK2 {
> @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 {
>  			reg_vdd_dram: BUCK3 {
>  				regulator-name = "buck3";
>  				regulator-min-microvolt = <850000>;
> -				regulator-max-microvolt = <900000>;
> +				regulator-max-microvolt = <950000>;
>  				regulator-boot-on;
>  				regulator-always-on;
>  			};
> -- 
> 2.33.0
>
Frieder Schrempf Oct. 5, 2021, 1:10 p.m. UTC | #4 
On 05.10.21 08:53, Shawn Guo wrote:
> On Thu, Sep 30, 2021 at 05:56:25PM +0200, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
>> should be 950 mV for DDR clock frequencies of 1.5 GHz.
>>
>> This information is taken from the datasheet and the uboot-imx code.
> 
> I'm wondering where the existing settings were coming from?

Good question, but I can't really retrace now how I actually determined
the values back then. Seems like I had failed to validate them properly.

> 
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> index 03b3516abd64..b12fb7ce6686 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> @@ -92,10 +92,12 @@ regulators {
>>  			reg_vdd_soc: BUCK1 {
>>  				regulator-name = "buck1";
>>  				regulator-min-microvolt = <800000>;
>> -				regulator-max-microvolt = <900000>;
>> +				regulator-max-microvolt = <850000>;
>>  				regulator-boot-on;
>>  				regulator-always-on;
>>  				regulator-ramp-delay = <3125>;
>> +				nxp,dvs-run-voltage = <850000>;
>> +				nxp,dvs-standby-voltage = <800000>;
>>  			};
>>  
>>  			reg_vdd_arm: BUCK2 {
>> @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 {
>>  			reg_vdd_dram: BUCK3 {
>>  				regulator-name = "buck3";
>>  				regulator-min-microvolt = <850000>;
>> -				regulator-max-microvolt = <900000>;
>> +				regulator-max-microvolt = <950000>;
>>  				regulator-boot-on;
>>  				regulator-always-on;
>>  			};
>> -- 
>> 2.33.0
>>
Shawn Guo Oct. 15, 2021, 3:51 a.m. UTC | #5 
On Tue, Oct 05, 2021 at 03:10:14PM +0200, Frieder Schrempf wrote:
> On 05.10.21 08:53, Shawn Guo wrote:
> > On Thu, Sep 30, 2021 at 05:56:25PM +0200, Frieder Schrempf wrote:
> >> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>
> >> VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
> >> should be 950 mV for DDR clock frequencies of 1.5 GHz.
> >>
> >> This information is taken from the datasheet and the uboot-imx code.
> > 
> > I'm wondering where the existing settings were coming from?
> 
> Good question, but I can't really retrace now how I actually determined
> the values back then. Seems like I had failed to validate them properly.

Please update commit log with these background info.

Shawn

> 
> > 
> >>
> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >> ---
> >>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> index 03b3516abd64..b12fb7ce6686 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> @@ -92,10 +92,12 @@ regulators {
> >>  			reg_vdd_soc: BUCK1 {
> >>  				regulator-name = "buck1";
> >>  				regulator-min-microvolt = <800000>;
> >> -				regulator-max-microvolt = <900000>;
> >> +				regulator-max-microvolt = <850000>;
> >>  				regulator-boot-on;
> >>  				regulator-always-on;
> >>  				regulator-ramp-delay = <3125>;
> >> +				nxp,dvs-run-voltage = <850000>;
> >> +				nxp,dvs-standby-voltage = <800000>;
> >>  			};
> >>  
> >>  			reg_vdd_arm: BUCK2 {
> >> @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 {
> >>  			reg_vdd_dram: BUCK3 {
> >>  				regulator-name = "buck3";
> >>  				regulator-min-microvolt = <850000>;
> >> -				regulator-max-microvolt = <900000>;
> >> +				regulator-max-microvolt = <950000>;
> >>  				regulator-boot-on;
> >>  				regulator-always-on;
> >>  			};
> >> -- 
> >> 2.33.0
> >>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
index 03b3516abd64..b12fb7ce6686 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
@@ -92,10 +92,12 @@  regulators {
 			reg_vdd_soc: BUCK1 {
 				regulator-name = "buck1";
 				regulator-min-microvolt = <800000>;
-				regulator-max-microvolt = <900000>;
+				regulator-max-microvolt = <850000>;
 				regulator-boot-on;
 				regulator-always-on;
 				regulator-ramp-delay = <3125>;
+				nxp,dvs-run-voltage = <850000>;
+				nxp,dvs-standby-voltage = <800000>;
 			};
 
 			reg_vdd_arm: BUCK2 {
@@ -111,7 +113,7 @@  reg_vdd_arm: BUCK2 {
 			reg_vdd_dram: BUCK3 {
 				regulator-name = "buck3";
 				regulator-min-microvolt = <850000>;
-				regulator-max-microvolt = <900000>;
+				regulator-max-microvolt = <950000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};