| Message ID | 20210916123920.48704-4-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fixups for slub | expand |
On 9/16/21 14:39, Miaohe Lin wrote: > In error path, the random_seq of slub cache might be leaked. Fix this by > using __kmem_cache_release() to release all the relevant resources. > > Fixes: 210e7a43fa90 ("mm: SLUB freelist randomization") > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index a56a6423d4e8..bf1793fb4ce5 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4210,8 +4210,8 @@ static int kmem_cache_open(struct kmem_cache *s, slab_flags_t flags) > if (alloc_kmem_cache_cpus(s)) > return 0; > > - free_kmem_cache_nodes(s); > error: > + __kmem_cache_release(s); > return -EINVAL; > } > >
diff --git a/mm/slub.c b/mm/slub.c index a56a6423d4e8..bf1793fb4ce5 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4210,8 +4210,8 @@ static int kmem_cache_open(struct kmem_cache *s, slab_flags_t flags) if (alloc_kmem_cache_cpus(s)) return 0; - free_kmem_cache_nodes(s); error: + __kmem_cache_release(s); return -EINVAL; }
In error path, the random_seq of slub cache might be leaked. Fix this by using __kmem_cache_release() to release all the relevant resources. Fixes: 210e7a43fa90 ("mm: SLUB freelist randomization") Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)