| Message ID | 20211007104301.76693-2-galpress@amazon.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | EFA dmabuf memory regions | expand |
Am 07.10.21 um 12:42 schrieb Gal Pressman: > The pin callback does not necessarily have to move the memory to system > memory, remove the sentence from the comment. > > Signed-off-by: Gal Pressman <galpress@amazon.com> > --- > include/linux/dma-buf.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index efdc56b9d95f..93830731a9a3 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -86,9 +86,7 @@ struct dma_buf_ops { > * @pin: > * > * This is called by dma_buf_pin() and lets the exporter know that the > - * DMA-buf can't be moved any more. The exporter should pin the buffer > - * into system memory to make sure it is generally accessible by other > - * devices. Maybe change that to something like "Ideally the exporter should pin the buffer so that it is generally accessible by all devices". Christian. > + * DMA-buf can't be moved any more. > * > * This is called with the &dmabuf.resv object locked and is mutual > * exclusive with @cache_sgt_mapping.
On 07/10/2021 13:44, Christian König wrote: > Am 07.10.21 um 12:42 schrieb Gal Pressman: >> The pin callback does not necessarily have to move the memory to system >> memory, remove the sentence from the comment. >> >> Signed-off-by: Gal Pressman <galpress@amazon.com> >> --- >> include/linux/dma-buf.h | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h >> index efdc56b9d95f..93830731a9a3 100644 >> --- a/include/linux/dma-buf.h >> +++ b/include/linux/dma-buf.h >> @@ -86,9 +86,7 @@ struct dma_buf_ops { >> * @pin: >> * >> * This is called by dma_buf_pin() and lets the exporter know that the >> - * DMA-buf can't be moved any more. The exporter should pin the buffer >> - * into system memory to make sure it is generally accessible by other >> - * devices. > > Maybe change that to something like "Ideally the exporter should pin the buffer > so that it is generally accessible by all devices". Sure, thanks.
diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h index efdc56b9d95f..93830731a9a3 100644 --- a/include/linux/dma-buf.h +++ b/include/linux/dma-buf.h @@ -86,9 +86,7 @@ struct dma_buf_ops { * @pin: * * This is called by dma_buf_pin() and lets the exporter know that the - * DMA-buf can't be moved any more. The exporter should pin the buffer - * into system memory to make sure it is generally accessible by other - * devices. + * DMA-buf can't be moved any more. * * This is called with the &dmabuf.resv object locked and is mutual * exclusive with @cache_sgt_mapping.
The pin callback does not necessarily have to move the memory to system memory, remove the sentence from the comment. Signed-off-by: Gal Pressman <galpress@amazon.com> --- include/linux/dma-buf.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)