| Message ID | 20211008070309.84205-1-drjones@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests] parse_keyval: Allow hex vals | expand |
On 08/10/2021 09.03, Andrew Jones wrote: > When parse_keyval was first written we didn't yet have strtol. > Now we do, let's give users more flexibility. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > lib/util.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/util.c b/lib/util.c > index a90554138952..682ca2db09e6 100644 > --- a/lib/util.c > +++ b/lib/util.c > @@ -4,6 +4,7 @@ > * This work is licensed under the terms of the GNU LGPL, version 2. > */ > #include <libcflat.h> > +#include <stdlib.h> > #include "util.h" > > int parse_keyval(char *s, long *val) > @@ -14,6 +15,6 @@ int parse_keyval(char *s, long *val) > if (!p) > return -1; > > - *val = atol(p+1); > + *val = strtol(p+1, NULL, 0); > return p - s; > } > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Fri, Oct 08, 2021 at 09:03:09AM +0200, Andrew Jones wrote: > When parse_keyval was first written we didn't yet have strtol. > Now we do, let's give users more flexibility. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > lib/util.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/util.c b/lib/util.c > index a90554138952..682ca2db09e6 100644 > --- a/lib/util.c > +++ b/lib/util.c > @@ -4,6 +4,7 @@ > * This work is licensed under the terms of the GNU LGPL, version 2. > */ > #include <libcflat.h> > +#include <stdlib.h> > #include "util.h" > > int parse_keyval(char *s, long *val) > @@ -14,6 +15,6 @@ int parse_keyval(char *s, long *val) > if (!p) > return -1; > > - *val = atol(p+1); > + *val = strtol(p+1, NULL, 0); > return p - s; > } > -- > 2.31.1 > Reviewed-by: Ricardo Koller <ricarkol@google.com>
On 08/10/2021 09:03, Andrew Jones wrote: > When parse_keyval was first written we didn't yet have strtol. > Now we do, let's give users more flexibility. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > lib/util.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/util.c b/lib/util.c > index a90554138952..682ca2db09e6 100644 > --- a/lib/util.c > +++ b/lib/util.c > @@ -4,6 +4,7 @@ > * This work is licensed under the terms of the GNU LGPL, version 2. > */ > #include <libcflat.h> > +#include <stdlib.h> > #include "util.h" > > int parse_keyval(char *s, long *val) > @@ -14,6 +15,6 @@ int parse_keyval(char *s, long *val) > if (!p) > return -1; > > - *val = atol(p+1); > + *val = strtol(p+1, NULL, 0); > return p - s; > } > Reviewed-by: Laurent Vivier <lvivier@redhat.com>
diff --git a/lib/util.c b/lib/util.c index a90554138952..682ca2db09e6 100644 --- a/lib/util.c +++ b/lib/util.c @@ -4,6 +4,7 @@ * This work is licensed under the terms of the GNU LGPL, version 2. */ #include <libcflat.h> +#include <stdlib.h> #include "util.h" int parse_keyval(char *s, long *val) @@ -14,6 +15,6 @@ int parse_keyval(char *s, long *val) if (!p) return -1; - *val = atol(p+1); + *val = strtol(p+1, NULL, 0); return p - s; }
When parse_keyval was first written we didn't yet have strtol. Now we do, let's give users more flexibility. Signed-off-by: Andrew Jones <drjones@redhat.com> --- lib/util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)