| Message ID | 20210824105038.1257926-24-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen: Build system improvements, now with out-of-tree build! | expand |
On 24.08.2021 12:50, Anthony PERARD wrote: > $(public-y) contains "public/arch-%" but when used by > $(PUBLIC_HEADERS) $(public-y) is filtered-out by the pattern > "public/arch-%". So $(public-y) content is never used. It has been this way from its very introduction, and iirc $(public-y) was meant to be an abstract construct to which other pieces could get added in principle. I'm having a slight preference to keeping things as they are, unless you tell me that this is getting in the way of anything. And to be clear there as well - if there are no other reasons than pure cleanup, and if somebody else approved of the removal, I wouldn't object. Jan > --- a/xen/include/Makefile > +++ b/xen/include/Makefile > @@ -39,9 +39,6 @@ cppflags-$(CONFIG_X86) += -m32 > > endif > > -public-$(CONFIG_X86) := $(wildcard public/arch-x86/*.h public/arch-x86/*/*.h) > -public-$(CONFIG_ARM) := $(wildcard public/arch-arm/*.h public/arch-arm/*/*.h) > - > .PHONY: all > all: $(headers-y) > > @@ -81,7 +78,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) > > all: headers.chk headers99.chk headers++.chk > > -PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard public/*.h public/*/*.h) $(public-y)) > +PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard public/*.h public/*/*.h)) > > PUBLIC_C99_HEADERS := public/io/9pfs.h public/io/pvcalls.h > PUBLIC_ANSI_HEADERS := $(filter-out public/%ctl.h public/xsm/% public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS)) >
diff --git a/xen/include/Makefile b/xen/include/Makefile index 95daa8a28975..65a938a66555 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -39,9 +39,6 @@ cppflags-$(CONFIG_X86) += -m32 endif -public-$(CONFIG_X86) := $(wildcard public/arch-x86/*.h public/arch-x86/*/*.h) -public-$(CONFIG_ARM) := $(wildcard public/arch-arm/*.h public/arch-arm/*/*.h) - .PHONY: all all: $(headers-y) @@ -81,7 +78,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) all: headers.chk headers99.chk headers++.chk -PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard public/*.h public/*/*.h) $(public-y)) +PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard public/*.h public/*/*.h)) PUBLIC_C99_HEADERS := public/io/9pfs.h public/io/pvcalls.h PUBLIC_ANSI_HEADERS := $(filter-out public/%ctl.h public/xsm/% public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS))
$(public-y) contains "public/arch-%" but when used by $(PUBLIC_HEADERS) $(public-y) is filtered-out by the pattern "public/arch-%". So $(public-y) content is never used. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Notes: v7: - new patch xen/include/Makefile | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)