| Message ID | cover.1633959458.git.agx@sigxcpu.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mxsfb/nwl/panels: media bus format fixes | expand |
Hi Guido, On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido Günther wrote: > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if > present") added bus format probing to mxsfb this exposed several issues in the > display stack as used on the Librem 5: > > The nwl bridge and the panels didn't bother to set any media bus formats and in > that case mxsfb would not pick a reasonable default. This series aims to fix > this. > > This series includes the patch from > https://lore.kernel.org/dri-devel/YVLYh%2FSgBritG%2FRJ@qwark.sigxcpu.org/ > with a `dev_warn` added. > > The patches are against 5.15-rc3. I've marked a single patch with a 'fixes' > which is enough to unbreak the display stack in 5.15. > > All patches of this series can be applied independently. > > Changes from v1: > - Review comment by Marek Vasut > https://lore.kernel.org/dri-devel/67e6056a-6157-795d-908d-d65cc803c03d@denx.de/ > Improve warning message > - Move mxsfb patches to the end of the queue and the actual nwl fix to the > front. > > Changes from v2: > - Review comments by Lucas Stach > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > Drop fixes tag from mxsfb driver and tweak commit message > - Add Reviewed-by from Lucas > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m9f3337a673ae1adbb1f0152a48270b0e1104b0c1 > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m5706d5b93cb6879b6bb4a1810b88800fe4180f74 > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > - Add Reviewd-by from Rober Foss > https://lore.kernel.org/dri-devel/CAG3jFyteqcPNZqrFsggCrnpDfsGGQvibfHBezW+1Hcf3-z91QQ@mail.gmail.com/ > > > > Guido Günther (5): > drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts > drm/panel: mantix: Add media bus format > drm/panel: st7703: Add media bus format > drm: mxsfb: Print failed bus format in hex > drm: mxsfb: Set fallback bus format when the bridge doesn't provide > one Full series are: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Sam
Hi Sam, On Mon, Oct 11, 2021 at 06:56:00PM +0200, Sam Ravnborg wrote: > Hi Guido, > > On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido Günther wrote: > > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if > > present") added bus format probing to mxsfb this exposed several issues in the > > display stack as used on the Librem 5: > > > > The nwl bridge and the panels didn't bother to set any media bus formats and in > > that case mxsfb would not pick a reasonable default. This series aims to fix > > this. > > > > This series includes the patch from > > https://lore.kernel.org/dri-devel/YVLYh%2FSgBritG%2FRJ@qwark.sigxcpu.org/ > > with a `dev_warn` added. > > > > The patches are against 5.15-rc3. I've marked a single patch with a 'fixes' > > which is enough to unbreak the display stack in 5.15. > > > > All patches of this series can be applied independently. > > > > Changes from v1: > > - Review comment by Marek Vasut > > https://lore.kernel.org/dri-devel/67e6056a-6157-795d-908d-d65cc803c03d@denx.de/ > > Improve warning message > > - Move mxsfb patches to the end of the queue and the actual nwl fix to the > > front. > > > > Changes from v2: > > - Review comments by Lucas Stach > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > > Drop fixes tag from mxsfb driver and tweak commit message > > - Add Reviewed-by from Lucas > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m9f3337a673ae1adbb1f0152a48270b0e1104b0c1 > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m5706d5b93cb6879b6bb4a1810b88800fe4180f74 > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > > - Add Reviewd-by from Rober Foss > > https://lore.kernel.org/dri-devel/CAG3jFyteqcPNZqrFsggCrnpDfsGGQvibfHBezW+1Hcf3-z91QQ@mail.gmail.com/ > > > > > > > > Guido Günther (5): > > drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts > > drm/panel: mantix: Add media bus format > > drm/panel: st7703: Add media bus format > > drm: mxsfb: Print failed bus format in hex > > drm: mxsfb: Set fallback bus format when the bridge doesn't provide > > one > > Full series are: > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Pushed the whole series to drm-misc-next. Thanks, -- Guido > > Sam >
commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if present") added bus format probing to mxsfb this exposed several issues in the display stack as used on the Librem 5: The nwl bridge and the panels didn't bother to set any media bus formats and in that case mxsfb would not pick a reasonable default. This series aims to fix this. This series includes the patch from https://lore.kernel.org/dri-devel/YVLYh%2FSgBritG%2FRJ@qwark.sigxcpu.org/ with a `dev_warn` added. The patches are against 5.15-rc3. I've marked a single patch with a 'fixes' which is enough to unbreak the display stack in 5.15. All patches of this series can be applied independently. Changes from v1: - Review comment by Marek Vasut https://lore.kernel.org/dri-devel/67e6056a-6157-795d-908d-d65cc803c03d@denx.de/ Improve warning message - Move mxsfb patches to the end of the queue and the actual nwl fix to the front. Changes from v2: - Review comments by Lucas Stach https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 Drop fixes tag from mxsfb driver and tweak commit message - Add Reviewed-by from Lucas https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m9f3337a673ae1adbb1f0152a48270b0e1104b0c1 https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m5706d5b93cb6879b6bb4a1810b88800fe4180f74 https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 - Add Reviewd-by from Rober Foss https://lore.kernel.org/dri-devel/CAG3jFyteqcPNZqrFsggCrnpDfsGGQvibfHBezW+1Hcf3-z91QQ@mail.gmail.com/ Guido Günther (5): drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts drm/panel: mantix: Add media bus format drm/panel: st7703: Add media bus format drm: mxsfb: Print failed bus format in hex drm: mxsfb: Set fallback bus format when the bridge doesn't provide one drivers/gpu/drm/bridge/nwl-dsi.c | 35 +++++++++++++++++++ drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 ++++- .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 9 +++++ drivers/gpu/drm/panel/panel-sitronix-st7703.c | 8 +++++ 4 files changed, 59 insertions(+), 1 deletion(-)