| Message ID | 20211012115242.10325-1-vegard.nossum@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: olimex-lcd-olinuxino: select CRC32 | expand |
Hi Thierry, I tried sending the patch below to Stefan Mavrodiev <stefan@olimex.com> (listed in MAINTAINERS for DRM DRIVER FOR OLIMEX LCD-OLINUXINO PANELS) but it bounced with "No such user at that domain". Will you take the patch and/or update the MAINTAINERS entry? Thanks, Vegard On 10/12/21 1:52 PM, Vegard Nossum wrote: > Fix the following build/link error by adding a dependency on the CRC32 > routines: > > ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe': > panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le' > > Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel") > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com> > --- > drivers/gpu/drm/panel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index beb581b96ecdc..418638e6e3b0a 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO > depends on OF > depends on I2C > depends on BACKLIGHT_CLASS_DEVICE > + select CRC32 > help > The panel is used with different sizes LCDs, from 480x272 to > 1280x800, and 24 bit per pixel. >
Hi Vegard, On Tue, Oct 12, 2021 at 01:52:42PM +0200, Vegard Nossum wrote: > Fix the following build/link error by adding a dependency on the CRC32 > routines: > > ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe': > panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le' > > Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel") > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com> thanks. Applied to drm-misc-fixes. It will turn up in master in a week or two. Sam
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index beb581b96ecdc..418638e6e3b0a 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO depends on OF depends on I2C depends on BACKLIGHT_CLASS_DEVICE + select CRC32 help The panel is used with different sizes LCDs, from 480x272 to 1280x800, and 24 bit per pixel.
Fix the following build/link error by adding a dependency on the CRC32 routines: ld: drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.o: in function `lcd_olinuxino_probe': panel-olimex-lcd-olinuxino.c:(.text+0x303): undefined reference to `crc32_le' Fixes: 17fd7a9d324fd ("drm/panel: Add support for Olimex LCD-OLinuXino panel") Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com> --- drivers/gpu/drm/panel/Kconfig | 1 + 1 file changed, 1 insertion(+)