| Message ID | 20211001101234.4247-4-arnaud.pouliquen@foss.st.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: restructure the remoteproc VirtIO device | expand |
On Fri, 1 Oct 2021 12:12:30 +0200, Arnaud Pouliquen wrote: > These both functions are only used by the remoteproc_virtio. > There is no reason to expose them in the API. > Move the functions in remoteproc_virtio.c > > Applied, thanks! [3/7] remoteproc: Remove vdev_to_rvdev and vdev_to_rproc from remoteproc API commit: 9955548919c47a6987b40d90a30fd56bbc043e7b Best regards,
Good morning, On Fri, Oct 01, 2021 at 12:12:30PM +0200, Arnaud Pouliquen wrote: > These both functions are only used by the remoteproc_virtio. s/"These both functions"/"Both of these functions" > There is no reason to expose them in the API. > Move the functions in remoteproc_virtio.c > > Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> > --- > drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++ > include/linux/remoteproc.h | 12 ------------ > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index 5e5a78b3243f..c9eecd2f9fb2 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -25,6 +25,18 @@ > > #include "remoteproc_internal.h" > > +static struct rproc_vdev *vdev_to_rvdev(struct virtio_device *vdev) > +{ > + return container_of(vdev->dev.parent, struct rproc_vdev, dev); > +} > + > +static struct rproc *vdev_to_rproc(struct virtio_device *vdev) > +{ > + struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); > + > + return rvdev->rproc; > +} > + > static int copy_dma_range_map(struct device *to, struct device *from) > { > const struct bus_dma_region *map = from->dma_range_map, *new_map, *r; > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > index 83c09ac36b13..e0600e1e5c17 100644 > --- a/include/linux/remoteproc.h > +++ b/include/linux/remoteproc.h > @@ -684,18 +684,6 @@ int rproc_coredump_add_custom_segment(struct rproc *rproc, > void *priv); > int rproc_coredump_set_elf_info(struct rproc *rproc, u8 class, u16 machine); > > -static inline struct rproc_vdev *vdev_to_rvdev(struct virtio_device *vdev) > -{ > - return container_of(vdev->dev.parent, struct rproc_vdev, dev); > -} > - > -static inline struct rproc *vdev_to_rproc(struct virtio_device *vdev) > -{ > - struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); > - > - return rvdev->rproc; > -} > - > void rproc_add_subdev(struct rproc *rproc, struct rproc_subdev *subdev); > > void rproc_remove_subdev(struct rproc *rproc, struct rproc_subdev *subdev); > -- > 2.17.1 >
diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index 5e5a78b3243f..c9eecd2f9fb2 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -25,6 +25,18 @@ #include "remoteproc_internal.h" +static struct rproc_vdev *vdev_to_rvdev(struct virtio_device *vdev) +{ + return container_of(vdev->dev.parent, struct rproc_vdev, dev); +} + +static struct rproc *vdev_to_rproc(struct virtio_device *vdev) +{ + struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); + + return rvdev->rproc; +} + static int copy_dma_range_map(struct device *to, struct device *from) { const struct bus_dma_region *map = from->dma_range_map, *new_map, *r; diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index 83c09ac36b13..e0600e1e5c17 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -684,18 +684,6 @@ int rproc_coredump_add_custom_segment(struct rproc *rproc, void *priv); int rproc_coredump_set_elf_info(struct rproc *rproc, u8 class, u16 machine); -static inline struct rproc_vdev *vdev_to_rvdev(struct virtio_device *vdev) -{ - return container_of(vdev->dev.parent, struct rproc_vdev, dev); -} - -static inline struct rproc *vdev_to_rproc(struct virtio_device *vdev) -{ - struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); - - return rvdev->rproc; -} - void rproc_add_subdev(struct rproc *rproc, struct rproc_subdev *subdev); void rproc_remove_subdev(struct rproc *rproc, struct rproc_subdev *subdev);
These both functions are only used by the remoteproc_virtio. There is no reason to expose them in the API. Move the functions in remoteproc_virtio.c Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> --- drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++ include/linux/remoteproc.h | 12 ------------ 2 files changed, 12 insertions(+), 12 deletions(-)