[03/14] block: remove useless caller argument to print_req_error()

Commit Message

Jens Axboe Oct. 17, 2021, 1:37 a.m. UTC

We have exactly one caller of this, just get rid of adding the useless
function name to the output.

Signed-off-by: Jens Axboe <[e-mail]>
---
 block/blk-core.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Christoph Hellwig Oct. 18, 2021, 8:42 a.m. UTC | #1

On Sat, Oct 16, 2021 at 07:37:37PM -0600, Jens Axboe wrote:
> We have exactly one caller of this, just get rid of adding the useless
> function name to the output.

Looks good,

Reviewed-by: Christoph Hellwig <[e-mail]>

Patch

diff --git a/block/blk-core.c b/block/blk-core.c
index d5b0258dd218..2596327f07d6 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -217,8 +217,7 @@  int blk_status_to_errno(blk_status_t status)
 }
 EXPORT_SYMBOL_GPL(blk_status_to_errno);
 
-static void print_req_error(struct request *req, blk_status_t status,
-		const char *caller)
+static void print_req_error(struct request *req, blk_status_t status)
 {
 	int idx = (__force int)status;
 
@@ -226,9 +225,9 @@  static void print_req_error(struct request *req, blk_status_t status,
 		return;
 
 	printk_ratelimited(KERN_ERR
-		"%s: %s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
+		"%s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
 		"phys_seg %u prio class %u\n",
-		caller, blk_errors[idx].name,
+		blk_errors[idx].name,
 		req->rq_disk ? req->rq_disk->disk_name : "?",
 		blk_rq_pos(req), req_op(req), blk_op_str(req_op(req)),
 		req->cmd_flags & ~REQ_OP_MASK,
@@ -1464,7 +1463,7 @@  bool blk_update_request(struct request *req, blk_status_t error,
 
 	if (unlikely(error && !blk_rq_is_passthrough(req) &&
 		     !(req->rq_flags & RQF_QUIET)))
-		print_req_error(req, error, __func__);
+		print_req_error(req, error);
 
 	blk_account_io_completion(req, nr_bytes);