| Message ID | fedb57c4f6d4373e0d6888d13ad2de3a1d315d81.1634235880.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 07fab5a469a5e01f8ca48c8459003d16c5c26f35 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ieee802154: Remove redundant 'flush_workqueue()' calls | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 3 this patch: 3 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 3 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
Hello Dave, Jakub. I have nothing else in my ieee802154 tree for net right now so it would be great if you could take it directly. If that poses a problem, let me know and I will get it in through my tree. On 14.10.21 20:26, Christophe JAILLET wrote: > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > - flush_workqueue(E); > destroy_workqueue(E); > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/net/ieee802154/ca8210.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c > index 3a2824f24caa..ece6ff6049f6 100644 > --- a/drivers/net/ieee802154/ca8210.c > +++ b/drivers/net/ieee802154/ca8210.c > @@ -2938,9 +2938,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv) > */ > static void ca8210_dev_com_clear(struct ca8210_priv *priv) > { > - flush_workqueue(priv->mlme_workqueue); > destroy_workqueue(priv->mlme_workqueue); > - flush_workqueue(priv->irq_workqueue); > destroy_workqueue(priv->irq_workqueue); > } > > Thanks Christophe for spotting and fixing this. Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> regards Stefan Schmidt
On Sat, 16 Oct 2021 22:54:52 +0200 Stefan Schmidt wrote: > I have nothing else in my ieee802154 tree for net right now so it would > be great if you could take it directly. Do you mean net or net-next? This looks like net-next material. Just to be sure, applying directly is not a problem.
Hello Jakub. On 18.10.21 23:14, Jakub Kicinski wrote: > On Sat, 16 Oct 2021 22:54:52 +0200 Stefan Schmidt wrote: >> I have nothing else in my ieee802154 tree for net right now so it would >> be great if you could take it directly. > > Do you mean net or net-next? This looks like net-next material. Yes, net-next, please. > Just to be sure, applying directly is not a problem. > Thanks. regards Stefan Schmidt
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 14 Oct 2021 20:26:14 +0200 you wrote: > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > [...] Here is the summary with links: - ieee802154: Remove redundant 'flush_workqueue()' calls https://git.kernel.org/netdev/net-next/c/07fab5a469a5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 3a2824f24caa..ece6ff6049f6 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -2938,9 +2938,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv) */ static void ca8210_dev_com_clear(struct ca8210_priv *priv) { - flush_workqueue(priv->mlme_workqueue); destroy_workqueue(priv->mlme_workqueue); - flush_workqueue(priv->irq_workqueue); destroy_workqueue(priv->irq_workqueue); }
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ieee802154/ca8210.c | 2 -- 1 file changed, 2 deletions(-)