| Message ID | 20210828111218.10026-1-jbx6244@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 | expand |
On Sat, 28 Aug 2021 13:12:17 +0200, Johan Jonker wrote: > With the conversion of rockchip-usb-phy.yaml a long time used fallback > string for rk3066a/rk3188 was added. The linux driver doesn't do much with > the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c > does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example > don't match. Remove the usb-phy fallback string for rk3066a/rk3188 > to prevent possible strange side effects. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Vinod, Kishon, Am Samstag, 28. August 2021, 13:12:17 CEST schrieb Johan Jonker: > With the conversion of rockchip-usb-phy.yaml a long time used fallback > string for rk3066a/rk3188 was added. The linux driver doesn't do much with > the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c > does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example > don't match. Remove the usb-phy fallback string for rk3066a/rk3188 > to prevent possible strange side effects. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> are you picking up this patch or can I get an Ack to just apply it together with the dts patch2? Thanks Heiko > --- > .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml > index f0fc8275d..499d55131 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml > @@ -11,13 +11,10 @@ maintainers: > > properties: > compatible: > - oneOf: > - - const: rockchip,rk3288-usb-phy > - - items: > - - enum: > - - rockchip,rk3066a-usb-phy > - - rockchip,rk3188-usb-phy > - - const: rockchip,rk3288-usb-phy > + enum: > + - rockchip,rk3066a-usb-phy > + - rockchip,rk3188-usb-phy > + - rockchip,rk3288-usb-phy > > "#address-cells": > const: 1 >
On 28-08-21, 13:12, Johan Jonker wrote: > With the conversion of rockchip-usb-phy.yaml a long time used fallback > string for rk3066a/rk3188 was added. The linux driver doesn't do much with > the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c > does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example > don't match. Remove the usb-phy fallback string for rk3066a/rk3188 > to prevent possible strange side effects. Applied, thanks
On Sat, 28 Aug 2021 13:12:17 +0200, Johan Jonker wrote: > With the conversion of rockchip-usb-phy.yaml a long time used fallback > string for rk3066a/rk3188 was added. The linux driver doesn't do much with > the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c > does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example > don't match. Remove the usb-phy fallback string for rk3066a/rk3188 > to prevent possible strange side effects. Applied, thanks! [2/2] ARM: dts: rockchip: remove usb-phy fallback string for rk3066a/rk3188 commit: 97ef6931208f7ab09f52dd291320aa53878aaa53 Best regards,
diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml index f0fc8275d..499d55131 100644 --- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml @@ -11,13 +11,10 @@ maintainers: properties: compatible: - oneOf: - - const: rockchip,rk3288-usb-phy - - items: - - enum: - - rockchip,rk3066a-usb-phy - - rockchip,rk3188-usb-phy - - const: rockchip,rk3288-usb-phy + enum: + - rockchip,rk3066a-usb-phy + - rockchip,rk3188-usb-phy + - rockchip,rk3288-usb-phy "#address-cells": const: 1
With the conversion of rockchip-usb-phy.yaml a long time used fallback string for rk3066a/rk3188 was added. The linux driver doesn't do much with the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example don't match. Remove the usb-phy fallback string for rk3066a/rk3188 to prevent possible strange side effects. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)