| Message ID | 20211019095738.2098486-2-adeep@lexina.in (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: hci_h5: btrtl: Add support for RTL8822CS hci_ver 0x08 | expand |
Hi Vyacheslav, > Add detection of RTL8822CS controller with hci_ver = 0x08 > > Signed-off-by: chbgdn <chbgdn@gmail.com> clear name please. > Signed-off-by: Vyacheslav Bocharov <adeep@lexina.in> > --- > drivers/bluetooth/btrtl.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c > index 1f8afa0244d8..60c4a9976d5a 100644 > --- a/drivers/bluetooth/btrtl.c > +++ b/drivers/bluetooth/btrtl.c > @@ -152,6 +152,13 @@ static const struct id_table ic_id_table[] = { > .fw_name = "rtl_bt/rtl8822cs_fw.bin", > .cfg_name = "rtl_bt/rtl8822cs_config" }, > > + /* 8822C with UART interface */ > + { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0x8, HCI_UART), > + .config_needed = true, > + .has_rom_version = true, > + .fw_name = "rtl_bt/rtl8822cs_fw.bin", > + .cfg_name = "rtl_bt/rtl8822cs_config" }, > + what about the .has_msft_ext here. Does this one support the Microsoft extension? Regards Marcel
19.10.2021 21:29, Marcel Holtmann wrote: > Hi Vyacheslav, > >> Add detection of RTL8822CS controller with hci_ver = 0x08 >> >> Signed-off-by: chbgdn <chbgdn@gmail.com> > > clear name please. If Bohdan doesn't answer, we can remove this line. >> + /* 8822C with UART interface */ >> + { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0x8, HCI_UART), >> + .config_needed = true, >> + .has_rom_version = true, >> + .fw_name = "rtl_bt/rtl8822cs_fw.bin", >> + .cfg_name = "rtl_bt/rtl8822cs_config" }, >> + > > what about the .has_msft_ext here. Does this one support the Microsoft extension? This is only a variant of the already added 8822c controller, so I simply copied the parameters and changed only hci_ver to 0x8. I found this controller on X96 TV Box and JetHome H1 device. It will also be necessary to update rtl8822cs_config in the linux-firmware repository from https://github.com/armbian/firmware/commit/5d685ad233b4dfd03a4d025fa0061f6b0f850cb3
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index 1f8afa0244d8..60c4a9976d5a 100644 --- a/drivers/bluetooth/btrtl.c +++ b/drivers/bluetooth/btrtl.c @@ -152,6 +152,13 @@ static const struct id_table ic_id_table[] = { .fw_name = "rtl_bt/rtl8822cs_fw.bin", .cfg_name = "rtl_bt/rtl8822cs_config" }, + /* 8822C with UART interface */ + { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0x8, HCI_UART), + .config_needed = true, + .has_rom_version = true, + .fw_name = "rtl_bt/rtl8822cs_fw.bin", + .cfg_name = "rtl_bt/rtl8822cs_config" }, + /* 8822C with USB interface */ { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0xa, HCI_USB), .config_needed = false,