[net-next,v2] phy: micrel: ksz8041nl: do not use power down mode

Commit Message

Francesco Dolcini Oct. 19, 2021, 7:16 p.m. UTC

From: Stefan Agner <[e-mail]>

Some Micrel KSZ8041NL PHY chips exhibit continuous RX errors after using
the power down mode bit (0.11). If the PHY is taken out of power down
mode in a certain temperature range, the PHY enters a weird state which
leads to continuously reporting RX errors. In that state, the MAC is not
able to receive or send any Ethernet frames and the activity LED is
constantly blinking. Since Linux is using the suspend callback when the
interface is taken down, ending up in that state can easily happen
during a normal startup.

Micrel confirmed the issue in errata DS80000700A [*], caused by abnormal
clock recovery when using power down mode. Even the latest revision (A4,
Revision ID 0x1513) seems to suffer that problem, and according to the
errata is not going to be fixed.

Remove the suspend/resume callback to avoid using the power down mode
completely.

[*] https://ww1.microchip.com/downloads/en/DeviceDoc/80000700A.pdf

Fixes: 1a5465f5d6a2 ("phy/micrel: Add suspend/resume support to Micrel PHYs")
Signed-off-by: Stefan Agner <[e-mail]>
Acked-by: Marcel Ziswiler <[e-mail]>
Signed-off-by: Francesco Dolcini <[e-mail]>
---
There was a previous attempt to merge a similar patch, see
https://lore.kernel.org/all/[e-mail]/.

I have not addressed (yet) a comment from Christophe Leroy, he suggested to
remove the suspend/resume callback also from PHY_ID_KSZ8041RNLI, however this
specific entry is for an undocumented phyid, while according to the datasheet
the entry I changed already cover the KSZ8041RNLI. I have no way to verify
anything about that so I took an extra conservative approach.

Changes in v2:
 Fixed commit message typos
 Added fixes tag (Jakub)
 Added comment with reference to the errata in place of the removed callback (Jakub)
---
 drivers/net/phy/micrel.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

[e-mail] Oct. 20, 2021, 1:40 p.m. UTC | #1

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Tue, 19 Oct 2021 21:16:47 +0200 you wrote:
> From: Stefan Agner <[e-mail]>
> 
> Some Micrel KSZ8041NL PHY chips exhibit continuous RX errors after using
> the power down mode bit (0.11). If the PHY is taken out of power down
> mode in a certain temperature range, the PHY enters a weird state which
> leads to continuously reporting RX errors. In that state, the MAC is not
> able to receive or send any Ethernet frames and the activity LED is
> constantly blinking. Since Linux is using the suspend callback when the
> interface is taken down, ending up in that state can easily happen
> during a normal startup.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] phy: micrel: ksz8041nl: do not use power down mode
    https://git.kernel.org/netdev/net-next/c/2641b62d2fab

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Patch

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index ff452669130a..44a24b99c894 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1676,8 +1676,9 @@  static struct phy_driver ksphy_driver[] = {
 	.get_sset_count = kszphy_get_sset_count,
 	.get_strings	= kszphy_get_strings,
 	.get_stats	= kszphy_get_stats,
-	.suspend	= genphy_suspend,
-	.resume		= genphy_resume,
+	/* No suspend/resume callbacks because of errata DS80000700A,
+	 * receiver error following software power down.
+	 */
 }, {
 	.phy_id		= PHY_ID_KSZ8041RNLI,
 	.phy_id_mask	= MICREL_PHY_ID_MASK,