| Message ID | 20211021140247.29691-1-fw@strlen.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1f83b835a3eaa5ae4bd825fb07182698bfc243ba |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] fcnal-test: kill hanging ping/nettest binaries on cleanup | expand |
Hi Florian, Quoting Florian Westphal (2021-10-21 16:02:47) > > + ip netns pids ${NSA} | xargs kill 2>/dev/null > ip netns del ${NSA} > fi > > + ip netns pids ${NSB} | xargs kill 2>/dev/null > ip netns del ${NSB} > + ip netns pids ${NSC} | xargs kill 2>/dev/null > ip netns del ${NSC} >/dev/null 2>&1 Alternatively you can use `xargs -r` (`--no-run-if-empty`) to avoid redirecting stderr to /dev/null. Thanks! Antoine
On 10/21/21 8:02 AM, Florian Westphal wrote: > On my box I see a bunch of ping/nettest processes hanging > around after fcntal-test.sh is done. > > Clean those up before netns deletion. > > Signed-off-by: Florian Westphal <fw@strlen.de> > --- > tools/testing/selftests/net/fcnal-test.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh > index 13350cd5c8ac..5aba16c52c2b 100755 > --- a/tools/testing/selftests/net/fcnal-test.sh > +++ b/tools/testing/selftests/net/fcnal-test.sh > @@ -439,10 +439,13 @@ cleanup() > ip -netns ${NSA} link set dev ${NSA_DEV} down > ip -netns ${NSA} link del dev ${NSA_DEV} > > + ip netns pids ${NSA} | xargs kill 2>/dev/null > ip netns del ${NSA} > fi > > + ip netns pids ${NSB} | xargs kill 2>/dev/null > ip netns del ${NSB} > + ip netns pids ${NSC} | xargs kill 2>/dev/null > ip netns del ${NSC} >/dev/null 2>&1 > } > > Acked-by: David Ahern <dsahern@kernel.org>
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 21 Oct 2021 16:02:47 +0200 you wrote: > On my box I see a bunch of ping/nettest processes hanging > around after fcntal-test.sh is done. > > Clean those up before netns deletion. > > Signed-off-by: Florian Westphal <fw@strlen.de> > > [...] Here is the summary with links: - [net] fcnal-test: kill hanging ping/nettest binaries on cleanup https://git.kernel.org/netdev/net/c/1f83b835a3ea You are awesome, thank you!
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh index 13350cd5c8ac..5aba16c52c2b 100755 --- a/tools/testing/selftests/net/fcnal-test.sh +++ b/tools/testing/selftests/net/fcnal-test.sh @@ -439,10 +439,13 @@ cleanup() ip -netns ${NSA} link set dev ${NSA_DEV} down ip -netns ${NSA} link del dev ${NSA_DEV} + ip netns pids ${NSA} | xargs kill 2>/dev/null ip netns del ${NSA} fi + ip netns pids ${NSB} | xargs kill 2>/dev/null ip netns del ${NSB} + ip netns pids ${NSC} | xargs kill 2>/dev/null ip netns del ${NSC} >/dev/null 2>&1 }
On my box I see a bunch of ping/nettest processes hanging around after fcntal-test.sh is done. Clean those up before netns deletion. Signed-off-by: Florian Westphal <fw@strlen.de> --- tools/testing/selftests/net/fcnal-test.sh | 3 +++ 1 file changed, 3 insertions(+)