| Message ID | 1-v3-57c1502c62fd+2190-ccw_mdev_jgg@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Move vfio_ccw to the new mdev API | expand |
On 10/1/21 1:52 PM, Jason Gunthorpe wrote: > Since the ccw_io_region was split out of the private the allocation no > longer needs the GFP_DMA. Remove it. > > Reported-by: Christoph Hellwig <hch@infradead.org> > Fixes: c98e16b2fa12 ("s390/cio: Convert ccw_io_region to pointer") > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com> > --- > drivers/s390/cio/vfio_ccw_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c > index 76099bcb765b45..371558ec92045d 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -161,7 +161,7 @@ static int vfio_ccw_sch_probe(struct subchannel *sch) > return -ENODEV; > } > > - private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); > + private = kzalloc(sizeof(*private), GFP_KERNEL); > if (!private) > return -ENOMEM; > >
On Fri, 2021-10-01 at 14:52 -0300, Jason Gunthorpe wrote: > Since the ccw_io_region was split out of the private the allocation > no > longer needs the GFP_DMA. Remove it. > > Reported-by: Christoph Hellwig <hch@infradead.org> > Fixes: c98e16b2fa12 ("s390/cio: Convert ccw_io_region to pointer") > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Eric Farman <farman@linux.ibm.com> > --- > drivers/s390/cio/vfio_ccw_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/cio/vfio_ccw_drv.c > b/drivers/s390/cio/vfio_ccw_drv.c > index 76099bcb765b45..371558ec92045d 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -161,7 +161,7 @@ static int vfio_ccw_sch_probe(struct subchannel > *sch) > return -ENODEV; > } > > - private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); > + private = kzalloc(sizeof(*private), GFP_KERNEL); > if (!private) > return -ENOMEM; >
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c index 76099bcb765b45..371558ec92045d 100644 --- a/drivers/s390/cio/vfio_ccw_drv.c +++ b/drivers/s390/cio/vfio_ccw_drv.c @@ -161,7 +161,7 @@ static int vfio_ccw_sch_probe(struct subchannel *sch) return -ENODEV; } - private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); + private = kzalloc(sizeof(*private), GFP_KERNEL); if (!private) return -ENOMEM;
Since the ccw_io_region was split out of the private the allocation no longer needs the GFP_DMA. Remove it. Reported-by: Christoph Hellwig <hch@infradead.org> Fixes: c98e16b2fa12 ("s390/cio: Convert ccw_io_region to pointer") Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> --- drivers/s390/cio/vfio_ccw_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)