diff mbox series

[v5,3/7] dt-bindings: display: sun4i: Add LVDS Dual-Link property

Message ID 20210929084234.1271915-4-maxime@cerno.tech (mailing list archive)
State New, archived
Headers show
Series drm/sun4i: Add support for dual-link LVDS on the A20 | expand

Commit Message

Maxime Ripard Sept. 29, 2021, 8:42 a.m. UTC
The Allwinner SoCs with two TCONs and LVDS output can use both to drive an
LVDS dual-link. Add a new property to express that link between these two
TCONs.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../bindings/display/allwinner,sun4i-a10-tcon.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Laurent Pinchart Oct. 22, 2021, 6:51 a.m. UTC | #1
Hi Maxime,

Thank you for the patch.

I may have written "Add LVDS link companion" property in the subject
line.

On Wed, Sep 29, 2021 at 10:42:30AM +0200, Maxime Ripard wrote:
> The Allwinner SoCs with two TCONs and LVDS output can use both to drive an
> LVDS dual-link. Add a new property to express that link between these two
> TCONs.
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../bindings/display/allwinner,sun4i-a10-tcon.yaml          | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> index 3a7d5d731712..d01b0689785c 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> @@ -113,6 +113,12 @@ properties:
>            - const: edp
>            - const: lvds
>  
> +  link-companion:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: >
> +      Phandle to the other TCON in the system used to drive a dual-link LVDS
> +      output.

Should this be expanded to indicate that the property shall be set in
both TCON instances ?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
index 3a7d5d731712..d01b0689785c 100644
--- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
+++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
@@ -113,6 +113,12 @@  properties:
           - const: edp
           - const: lvds
 
+  link-companion:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: >
+      Phandle to the other TCON in the system used to drive a dual-link LVDS
+      output.
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports