mbox series

[RESEND,0/2] Fix machine parameter default_bus_bypass_iommu

Message ID 20211013160607.649990-1-jean-philippe@linaro.org (mailing list archive)
Headers show
Series Fix machine parameter default_bus_bypass_iommu | expand

Message

Jean-Philippe Brucker Oct. 13, 2021, 4:06 p.m. UTC
The machine option "default_bus_bypass_iommu" is broken since commit
d8fb7d0969d5 ("vl: switch -M parsing to keyval"). Fix both machines that
implement it.

Resending with Review and Tested tags, no other change since last
posting:
https://lore.kernel.org/qemu-devel/20210811085842.2511545-1-jean-philippe@linaro.org/

The fix was suggested by Paolo:
https://lore.kernel.org/qemu-devel/6e233344-dd09-598f-082a-afe73d788b33@redhat.com/

Jean-Philippe Brucker (2):
  hw/arm/virt: Rename default_bus_bypass_iommu
  hw/i386: Rename default_bus_bypass_iommu

 hw/arm/virt.c | 4 ++--
 hw/i386/pc.c  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Jean-Philippe Brucker Oct. 22, 2021, 12:23 p.m. UTC | #1
Hi Paolo,

On Wed, Oct 13, 2021 at 05:06:06PM +0100, Jean-Philippe Brucker wrote:
> The machine option "default_bus_bypass_iommu" is broken since commit
> d8fb7d0969d5 ("vl: switch -M parsing to keyval"). Fix both machines that
> implement it.

Please could you take a look at these fixes?  Another patch adds a test
that uses default_bus_bypass_iommu [1], and is blocked by this.

Thanks,
Jean

[1] https://lore.kernel.org/qemu-devel/20211020172745.620101-11-jean-philippe@linaro.org/

> 
> Resending with Review and Tested tags, no other change since last
> posting:
> https://lore.kernel.org/qemu-devel/20210811085842.2511545-1-jean-philippe@linaro.org/
> 
> The fix was suggested by Paolo:
> https://lore.kernel.org/qemu-devel/6e233344-dd09-598f-082a-afe73d788b33@redhat.com/
> 
> Jean-Philippe Brucker (2):
>   hw/arm/virt: Rename default_bus_bypass_iommu
>   hw/i386: Rename default_bus_bypass_iommu
> 
>  hw/arm/virt.c | 4 ++--
>  hw/i386/pc.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> -- 
> 2.33.0
>
Philippe Mathieu-Daudé Oct. 22, 2021, 12:33 p.m. UTC | #2
On 10/13/21 18:06, Jean-Philippe Brucker wrote:
> The machine option "default_bus_bypass_iommu" is broken since commit
> d8fb7d0969d5 ("vl: switch -M parsing to keyval"). Fix both machines that
> implement it.
> 
> Resending with Review and Tested tags, no other change since last
> posting:
> https://lore.kernel.org/qemu-devel/20210811085842.2511545-1-jean-philippe@linaro.org/
> 
> The fix was suggested by Paolo:
> https://lore.kernel.org/qemu-devel/6e233344-dd09-598f-082a-afe73d788b33@redhat.com/
> 
> Jean-Philippe Brucker (2):
>   hw/arm/virt: Rename default_bus_bypass_iommu
>   hw/i386: Rename default_bus_bypass_iommu
> 
>  hw/arm/virt.c | 4 ++--
>  hw/i386/pc.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>