[net-next,0/3] Introduce supported interfaces bitmap

Message

Russell King (Oracle) Oct. 26, 2021, 10:05 a.m. UTC

This series introduces a new bitmap to allow us to indicate which
phy_interface_t modes are supported.

Currently, phylink will call ->validate with PHY_INTERFACE_MODE_NA to
request all link mode capabilities from the MAC driver before choosing
an interface to use. This leads in some cases to some rather hairly
code. This can be simplified if phylink is aware of the interface modes
that  the MAC supports, and it can instead walk those modes, calling
->validate for each one, and combining the results.

This series merely introduces the support; there is no change of
behaviour until MAC drivers populate their supported_interfaces bitmap.

 drivers/net/phy/phylink.c | 36 ++++++++++++++++++++++++++++++++++++
 include/linux/phy.h       | 34 ++++++++++++++++++++++++++++++++++
 include/linux/phylink.h   | 13 +++++++++++--
 3 files changed, 81 insertions(+), 2 deletions(-)

Comments

[e-mail] Oct. 26, 2021, 2:20 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Tue, 26 Oct 2021 11:05:36 +0100 you wrote:
> This series introduces a new bitmap to allow us to indicate which
> phy_interface_t modes are supported.
> 
> Currently, phylink will call ->validate with PHY_INTERFACE_MODE_NA to
> request all link mode capabilities from the MAC driver before choosing
> an interface to use. This leads in some cases to some rather hairly
> code. This can be simplified if phylink is aware of the interface modes
> that  the MAC supports, and it can instead walk those modes, calling
> ->validate for each one, and combining the results.
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net: phy: add phy_interface_t bitmap support
    https://git.kernel.org/netdev/net-next/c/8e20f591f204
  - [net-next,2/3] net: phylink: add MAC phy_interface_t bitmap
    https://git.kernel.org/netdev/net-next/c/38c310eb46f5
  - [net-next,3/3] net: phylink: use supported_interfaces for phylink validation
    https://git.kernel.org/netdev/net-next/c/d25f3a74f30a

You are awesome, thank you!