| Message ID | 20211026093828.4188145-2-CTLIN0@nuvoton.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Make genaral and simple for new sof machine driver | expand |
On 10/26/21 4:38 AM, David Lin wrote: > Use set_jack ops to set jack for new machine drivers. Meanwhile, > the old machine drivers can still call previous export function > "nau8825_enable_jack_detect". > > Co-Developed-by: Mac Chiang <mac.chiang@intel.com> if you use the Co-developed-by: tag (no capital letter after 'C'), you still need to provide your Signed-off-by: tag https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by same comment for the 2 other patches in this series. > Signed-off-by: David Lin <CTLIN0@nuvoton.com> > --- > sound/soc/codecs/nau8825.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c > index 67de0e49ccf4..c845f19b7c41 100644 > --- a/sound/soc/codecs/nau8825.c > +++ b/sound/soc/codecs/nau8825.c > @@ -2416,6 +2416,12 @@ static int __maybe_unused nau8825_resume(struct snd_soc_component *component) > return 0; > } > > +static int nau8825_set_jack(struct snd_soc_component *component, > + struct snd_soc_jack *jack, void *data) > +{ > + return nau8825_enable_jack_detect(component, jack); > +} > + > static const struct snd_soc_component_driver nau8825_component_driver = { > .probe = nau8825_component_probe, > .remove = nau8825_component_remove, > @@ -2430,6 +2436,7 @@ static const struct snd_soc_component_driver nau8825_component_driver = { > .num_dapm_widgets = ARRAY_SIZE(nau8825_dapm_widgets), > .dapm_routes = nau8825_dapm_routes, > .num_dapm_routes = ARRAY_SIZE(nau8825_dapm_routes), > + .set_jack = nau8825_set_jack, > .suspend_bias_off = 1, > .idle_bias_on = 1, > .use_pmdown_time = 1, >
On Tue, Oct 26, 2021 at 12:35:33PM -0500, Pierre-Louis Bossart wrote: > > > On 10/26/21 4:38 AM, David Lin wrote: > > Use set_jack ops to set jack for new machine drivers. Meanwhile, > > the old machine drivers can still call previous export function > > "nau8825_enable_jack_detect". > > > > Co-Developed-by: Mac Chiang <mac.chiang@intel.com> > > if you use the Co-developed-by: tag (no capital letter after 'C'), you > still need to provide your Signed-off-by: tag > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > > same comment for the 2 other patches in this series. > > > Signed-off-by: David Lin <CTLIN0@nuvoton.com> The signoff is there AFAICT?
>>> Co-Developed-by: Mac Chiang <mac.chiang@intel.com> >> >> if you use the Co-developed-by: tag (no capital letter after 'C'), you >> still need to provide your Signed-off-by: tag >> >> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by >> >> same comment for the 2 other patches in this series. >> >>> Signed-off-by: David Lin <CTLIN0@nuvoton.com> > > The signoff is there AFAICT? I meant the Signed-off-by: tag of the first co-developer. The rule is: " Since Co-developed-by: denotes authorship, every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author. " so each patch should be tagged as follows: Co-developed-by: Mac Chiang <mac.chiang@intel.com> Signed-off-by: Mac Chiang <mac.chiang@intel.com> Signed-off-by: David Lin <CTLIN0@nuvoton.com>
On Tue, Oct 26, 2021 at 01:53:56PM -0500, Pierre-Louis Bossart wrote: > >>> Signed-off-by: David Lin <CTLIN0@nuvoton.com> > > The signoff is there AFAICT? > I meant the Signed-off-by: tag of the first co-developer. The rule is: > > " > Since Co-developed-by: denotes authorship, every Co-developed-by: must > be immediately followed by a Signed-off-by: of the associated co-author. > " > so each patch should be tagged as follows: > Co-developed-by: Mac Chiang <mac.chiang@intel.com> > Signed-off-by: Mac Chiang <mac.chiang@intel.com> > Signed-off-by: David Lin <CTLIN0@nuvoton.com> Oh, that makes the whole thing seem substantially less purposeful than I'd though. David, please update to reflect this.
On 2021/10/27 上午 03:05, Mark Brown wrote: > On Tue, Oct 26, 2021 at 01:53:56PM -0500, Pierre-Louis Bossart wrote: > >>>>> Signed-off-by: David Lin <CTLIN0@nuvoton.com> >>> The signoff is there AFAICT? >> I meant the Signed-off-by: tag of the first co-developer. The rule is: >> >> " >> Since Co-developed-by: denotes authorship, every Co-developed-by: must >> be immediately followed by a Signed-off-by: of the associated co-author. >> " >> so each patch should be tagged as follows: >> Co-developed-by: Mac Chiang <mac.chiang@intel.com> >> Signed-off-by: Mac Chiang <mac.chiang@intel.com> >> Signed-off-by: David Lin <CTLIN0@nuvoton.com> > Oh, that makes the whole thing seem substantially less purposeful than > I'd though. David, please update to reflect this. I appreciate your guide very much. I'll send patch again.
diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 67de0e49ccf4..c845f19b7c41 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -2416,6 +2416,12 @@ static int __maybe_unused nau8825_resume(struct snd_soc_component *component) return 0; } +static int nau8825_set_jack(struct snd_soc_component *component, + struct snd_soc_jack *jack, void *data) +{ + return nau8825_enable_jack_detect(component, jack); +} + static const struct snd_soc_component_driver nau8825_component_driver = { .probe = nau8825_component_probe, .remove = nau8825_component_remove, @@ -2430,6 +2436,7 @@ static const struct snd_soc_component_driver nau8825_component_driver = { .num_dapm_widgets = ARRAY_SIZE(nau8825_dapm_widgets), .dapm_routes = nau8825_dapm_routes, .num_dapm_routes = ARRAY_SIZE(nau8825_dapm_routes), + .set_jack = nau8825_set_jack, .suspend_bias_off = 1, .idle_bias_on = 1, .use_pmdown_time = 1,
Use set_jack ops to set jack for new machine drivers. Meanwhile, the old machine drivers can still call previous export function "nau8825_enable_jack_detect". Co-Developed-by: Mac Chiang <mac.chiang@intel.com> Signed-off-by: David Lin <CTLIN0@nuvoton.com> --- sound/soc/codecs/nau8825.c | 7 +++++++ 1 file changed, 7 insertions(+)