diff mbox series

[1/3] wcn36xx: add debug prints for sw_scan start/complete

Message ID 20211023003949.3082900-2-benl@squareup.com (mailing list archive)
State Superseded
Headers show
Series wcn36xx: software scanning improvements | expand

Commit Message

Benjamin Li Oct. 23, 2021, 12:39 a.m. UTC
Add some MAC debug prints for more easily demarcating a software scan
when parsing logs.

Signed-off-by: Benjamin Li <benl@squareup.com>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Kalle Valo Oct. 27, 2021, 7:53 a.m. UTC | #1
Benjamin Li <benl@squareup.com> wrote:

> Add some MAC debug prints for more easily demarcating a software scan
> when parsing logs.
> 
> Signed-off-by: Benjamin Li <benl@squareup.com>

Failed to build:

In file included from ./include/linux/bitops.h:7,
                 from ./include/linux/kernel.h:12,
                 from ./include/linux/interrupt.h:6,
                 from drivers/net/wireless/ath/wcn36xx/dxe.c:25:
drivers/net/wireless/ath/wcn36xx/dxe.c: In function '_wcn36xx_dxe_tx_channel_is_empty':
./include/linux/typecheck.h:12:25: error: comparison of distinct pointer types lacks a cast [-Werror]
   12 |         (void)(&__dummy == &__dummy2); \
      |                         ^~
./include/linux/spinlock.h:255:17: note: in expansion of macro 'typecheck'
  255 |                 typecheck(unsigned long, flags);        \
      |                 ^~~~~~~~~
./include/linux/spinlock.h:393:9: note: in expansion of macro 'raw_spin_lock_irqsave'
  393 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
      |         ^~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/dxe.c:844:9: note: in expansion of macro 'spin_lock_irqsave'
  844 |         spin_lock_irqsave(&ch->lock, flags);
      |         ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:277: drivers/net/wireless/ath/wcn36xx/dxe.o] Error 1
make[4]: *** [scripts/Makefile.build:540: drivers/net/wireless/ath/wcn36xx] Error 2
make[3]: *** [scripts/Makefile.build:540: drivers/net/wireless/ath] Error 2
make[2]: *** [scripts/Makefile.build:540: drivers/net/wireless] Error 2
make[1]: *** [scripts/Makefile.build:540: drivers/net] Error 2
make: *** [Makefile:1868: drivers] Error 2

3 patches set to Changes Requested.

12579221 [1/3] wcn36xx: add debug prints for sw_scan start/complete
12579223 [2/3] wcn36xx: implement flush op to speed up connected scan
12579225 [3/3] wcn36xx: ensure pairing of init_scan/finish_scan and start_scan/end_scan
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index 263af65a889ab..81ac86eeaf60b 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -711,6 +711,8 @@  static void wcn36xx_sw_scan_start(struct ieee80211_hw *hw,
 	struct wcn36xx *wcn = hw->priv;
 	struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
 
+	wcn36xx_dbg(WCN36XX_DBG_MAC, "sw_scan_start");
+
 	wcn->sw_scan = true;
 	wcn->sw_scan_vif = vif;
 	wcn->sw_scan_channel = 0;
@@ -725,6 +727,8 @@  static void wcn36xx_sw_scan_complete(struct ieee80211_hw *hw,
 {
 	struct wcn36xx *wcn = hw->priv;
 
+	wcn36xx_dbg(WCN36XX_DBG_MAC, "sw_scan_complete");
+
 	/* ensure that any scan session is finished */
 	wcn36xx_smd_finish_scan(wcn, HAL_SYS_MODE_SCAN, wcn->sw_scan_vif);
 	wcn->sw_scan = false;