| Message ID | 20211030091706.25470-1-pauk.denis@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Update ASUS WMI supported boards | expand |
On Sat, Oct 30, 2021 at 12:17 PM Denis Pauk <pauk.denis@gmail.com> wrote: > > Add support by WMI interface provided by Asus for B550/X570 boards: > * PRIME X570-PRO, > * ROG CROSSHAIR VIII HERO > * ROG CROSSHAIR VIII DARK HERO > * ROG CROSSHAIR VIII FORMULA > * ROG STRIX X570-E GAMING > * ROG STRIX B550-E GAMING > > Add support by WMI interface provided by Asus for X370/X470/ > B450/X399 boards: > * ROG CROSSHAIR VI HERO, > * PRIME X399-A, > * PRIME X470-PRO, > * ROG CROSSHAIR VI EXTREME, > * ROG CROSSHAIR VI HERO (WI-FI AC), > * ROG CROSSHAIR VII HERO, > * ROG CROSSHAIR VII HERO (WI-FI), > * ROG STRIX B450-E GAMING, > * ROG STRIX B450-F GAMING, > * ROG STRIX B450-I GAMING, > * ROG STRIX X399-E GAMING, > * ROG STRIX X470-F GAMING, > * ROG STRIX X470-I GAMING, > * ROG ZENITH EXTREME, > * ROG ZENITH EXTREME ALPHA. > > @Andy Shevchenko: I have added your changes to asus_wmi_ec_sensors. Have I > correctly applied changes? Thank you. Thanks! Since I have no hardware, you may answer better than me, i.e. if it works, then you did a great job! > @Guenter Roeck: I have adeed comments about units in the > asus_wmi_scale_sensor_value. > > I have added ACPI_FREE for results to all case of > usage wmi_evaluate_method. Is it correct? > > Could you please review? I'll look at it later.
On Sat, Oct 30, 2021 at 2:22 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sat, Oct 30, 2021 at 12:17 PM Denis Pauk <pauk.denis@gmail.com> wrote: > > Could you please review? > > I'll look at it later. I briefly looked into it and found some subtle changes that might be incorporated. However, I will send the full review if there will be a new version (of the series) for sure. Let Guenter make his comment on this first.
Add support by WMI interface provided by Asus for B550/X570 boards: * PRIME X570-PRO, * ROG CROSSHAIR VIII HERO * ROG CROSSHAIR VIII DARK HERO * ROG CROSSHAIR VIII FORMULA * ROG STRIX X570-E GAMING * ROG STRIX B550-E GAMING Add support by WMI interface provided by Asus for X370/X470/ B450/X399 boards: * ROG CROSSHAIR VI HERO, * PRIME X399-A, * PRIME X470-PRO, * ROG CROSSHAIR VI EXTREME, * ROG CROSSHAIR VI HERO (WI-FI AC), * ROG CROSSHAIR VII HERO, * ROG CROSSHAIR VII HERO (WI-FI), * ROG STRIX B450-E GAMING, * ROG STRIX B450-F GAMING, * ROG STRIX B450-I GAMING, * ROG STRIX X399-E GAMING, * ROG STRIX X470-F GAMING, * ROG STRIX X470-I GAMING, * ROG ZENITH EXTREME, * ROG ZENITH EXTREME ALPHA. @Andy Shevchenko: I have added your changes to asus_wmi_ec_sensors. Have I correctly applied changes? Thank you. @Guenter Roeck: I have adeed comments about units in the asus_wmi_scale_sensor_value. I have added ACPI_FREE for results to all case of usage wmi_evaluate_method. Is it correct? Could you please review? Signed-off-by: Denis Pauk <pauk.denis@gmail.com> Signed-off-by: Ed Brindley <kernel@maidavale.org> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- Changes in v9: - Fix memory leaks in asus_wmi_ec_block_read() - Fix buffer and parameter lengths in decode and encode algorithms - Simplify encoding in read query - Reshuffle structures to make pointer arithmetics simpler or no-op in some cases - Shuffle parameters in some functions to make it more logical - Use temporary variable for EC info data structure - Many indentation fixes to improve readability (breaks 80 characters rule) - Fix memory leaks in asus_wmi_sensors:asus_wmi_*(). Changes in v8: - Add seprate patch for ProArt X570-CREATOR WIFI support. - Fix codestyle in defines and comments. - Fix buffer length calculation. - Use hex2bin/bin2hex for convert values in buffers. - Remove unrequired acpi_os_free usage. - Call mutex_lock inside of functions. Changes in v7: - Use for directly get sensors list by board. - Add depends on ACPI_WMI to Kconfig. - Add response buffer size check in asus_wmi_ec_decode_reply_buffer. - Clean up defines names. Changes in v6: - asus_wmi_ec_sensors: Generate query for all sensors on sensors setup - asus_wmi_ec_sensors: Move binary to sensor value logic to separate get_sensor_value (by Eugene Shalygin) - asus_wmi_ec_sensors: Use acpi_os_free without NULL pointer check. - Add asus_wmi_sensor to documentation index. - Add asus_wmi_ec_sensor to documentation index. Changes in v5: - Fixes build issue reported by kernel test robot with disabled ACPI_WMI. - asus_wmi_sensors: Remove sensor->name check as always evaluated to true. Changes in v4: - Implement wmi driver instead platform driver. - Update documentation with known issues. Changes in v3: - Use MODULE_DEVICE_TABLE for match devices. - asus_wmi_ec_sensors: Use get_unaligned_be32 instead incorrectly used get_unaligned_le32. - Add documentaion for drivers. Changes in v2: - asus_wmi_ec_sensors: Rename asus_wmi_sensors to asus_wmi_ec_sensors for B550/X570 boards. - asus_wmi_ec_sensors: Use utf8s_to_utf16s/utf16s_to_utf8s instead handmade fuctions. - asus_wmi_ec_sensors: Use post increment. - asus_wmi_ec_sensors: Use get_unaligned* for convert values. - asus_wmi_ec_sensors: Use PTR_ERR_OR_ZERO. - asus_wmi_ec_sensors: Specify per-board sensors in a declarative way (by Eugene Shalygin). - asus_wmi_sensors: Add support for X370/X470/B450/X399 boards. --- Denis Pauk (2): hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI. hwmon: (asus_wmi_sensors) Support X370 Asus WMI. Documentation/hwmon/asus_wmi_ec_sensors.rst | 35 ++ Documentation/hwmon/asus_wmi_sensors.rst | 74 +++ Documentation/hwmon/index.rst | 2 + MAINTAINERS | 8 + drivers/hwmon/Kconfig | 24 + drivers/hwmon/Makefile | 2 + drivers/hwmon/asus_wmi_ec_sensors.c | 612 ++++++++++++++++++ drivers/hwmon/asus_wmi_sensors.c | 657 ++++++++++++++++++++ 8 files changed, 1414 insertions(+) create mode 100644 Documentation/hwmon/asus_wmi_ec_sensors.rst create mode 100644 Documentation/hwmon/asus_wmi_sensors.rst create mode 100644 drivers/hwmon/asus_wmi_ec_sensors.c create mode 100644 drivers/hwmon/asus_wmi_sensors.c base-commit: 10f0d2ab9aa672707559d46601fd35544759ff70