| Message ID | 20211031234137.87070-1-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9cb6de45a006a9799ec399bce60d64b6d4fcc4af |
| Headers | show |
| Series | [v2,1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity | expand |
On 01/11/2021 00:41, Paul Cercueil wrote: > The reset GPIO was marked active-high, which is against what's specified > in the documentation. Mark the reset GPIO as active-low. With this > change, Bluetooth can now be used on the i9100. > > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2") > Cc: stable@vger.kernel.org > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Looks good, thanks. I'll take it after the merge window. Best regards, Krzysztof
On Sun, 31 Oct 2021 23:41:36 +0000, Paul Cercueil wrote: > The reset GPIO was marked active-high, which is against what's specified > in the documentation. Mark the reset GPIO as active-low. With this > change, Bluetooth can now be used on the i9100. > > Applied, thanks! [1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity commit: 9cb6de45a006a9799ec399bce60d64b6d4fcc4af [2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup commit: 8e14b530f8c90346eab43c7b59b03ff9fec7d171 Best regards,
On 15/11/2021 14:11, Krzysztof Kozlowski wrote: > On Sun, 31 Oct 2021 23:41:36 +0000, Paul Cercueil wrote: >> The reset GPIO was marked active-high, which is against what's specified >> in the documentation. Mark the reset GPIO as active-low. With this >> change, Bluetooth can now be used on the i9100. >> >> > > Applied, thanks! > > [1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity > commit: 9cb6de45a006a9799ec399bce60d64b6d4fcc4af > [2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup > commit: 8e14b530f8c90346eab43c7b59b03ff9fec7d171 > Applied with fixed title. Please use prefix matching history (git log --oneline). Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts index 55922176807e..5f5d9b135736 100644 --- a/arch/arm/boot/dts/exynos4210-i9100.dts +++ b/arch/arm/boot/dts/exynos4210-i9100.dts @@ -827,7 +827,7 @@ bluetooth { compatible = "brcm,bcm4330-bt"; shutdown-gpios = <&gpl0 4 GPIO_ACTIVE_HIGH>; - reset-gpios = <&gpl1 0 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpl1 0 GPIO_ACTIVE_LOW>; device-wakeup-gpios = <&gpx3 1 GPIO_ACTIVE_HIGH>; host-wakeup-gpios = <&gpx2 6 GPIO_ACTIVE_HIGH>; };
The reset GPIO was marked active-high, which is against what's specified in the documentation. Mark the reset GPIO as active-low. With this change, Bluetooth can now be used on the i9100. Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2") Cc: stable@vger.kernel.org Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)