| Message ID | 20210915223117.7857-4-jitao.shi@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | force hsa hbp hfp packets multiple of lanenum to avoid screen shift | expand |
Hi Xin, Please help to review the changes in anx7625.c On Thu, 2021-09-16 at 06:31 +0800, Jitao Shi wrote: > This device requires the packets on lanes aligned at the end to fix > screen shift or scroll. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c > b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 14d73fb1dd15..d76fb63fa9f7 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1327,6 +1327,7 @@ static int anx7625_attach_dsi(struct > anx7625_data *ctx) > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > MIPI_DSI_MODE_NO_EOT_PACKET | > MIPI_DSI_MODE_VIDEO_HSE; > + dsi->hs_packet_end_aligned = true; > > if (mipi_dsi_attach(dsi) < 0) { > DRM_DEV_ERROR(dev, "fail to attach dsi to host.\n");
On Mon, Nov 01, 2021 at 11:16:15AM +0800, Jitao Shi wrote: > Hi Xin, > > Please help to review the changes in anx7625.c > > On Thu, 2021-09-16 at 06:31 +0800, Jitao Shi wrote: > > This device requires the packets on lanes aligned at the end to fix > > screen shift or scroll. > > > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c > > b/drivers/gpu/drm/bridge/analogix/anx7625.c > > index 14d73fb1dd15..d76fb63fa9f7 100644 > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > @@ -1327,6 +1327,7 @@ static int anx7625_attach_dsi(struct > > anx7625_data *ctx) > > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > > MIPI_DSI_MODE_NO_EOT_PACKET | > > MIPI_DSI_MODE_VIDEO_HSE; > > + dsi->hs_packet_end_aligned = true; Looks good, it's OK for me. Reviewed-by: Xin Ji <xji@analogixsemi.com> > > > > if (mipi_dsi_attach(dsi) < 0) { > > DRM_DEV_ERROR(dev, "fail to attach dsi to host.\n");
On Tue, 2 Nov 2021 at 02:56, Xin Ji <xji@analogixsemi.com> wrote: > > On Mon, Nov 01, 2021 at 11:16:15AM +0800, Jitao Shi wrote: > > Hi Xin, > > > > Please help to review the changes in anx7625.c > > > > On Thu, 2021-09-16 at 06:31 +0800, Jitao Shi wrote: > > > This device requires the packets on lanes aligned at the end to fix > > > screen shift or scroll. > > > > > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > > > --- > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > index 14d73fb1dd15..d76fb63fa9f7 100644 > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > @@ -1327,6 +1327,7 @@ static int anx7625_attach_dsi(struct > > > anx7625_data *ctx) > > > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > > > MIPI_DSI_MODE_NO_EOT_PACKET | > > > MIPI_DSI_MODE_VIDEO_HSE; > > > + dsi->hs_packet_end_aligned = true; > > Looks good, it's OK for me. > Reviewed-by: Xin Ji <xji@analogixsemi.com> Acked-by: Robert Foss <robert.foss@linaro.org>
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 14d73fb1dd15..d76fb63fa9f7 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1327,6 +1327,7 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_MODE_VIDEO_HSE; + dsi->hs_packet_end_aligned = true; if (mipi_dsi_attach(dsi) < 0) { DRM_DEV_ERROR(dev, "fail to attach dsi to host.\n");
This device requires the packets on lanes aligned at the end to fix screen shift or scroll. Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + 1 file changed, 1 insertion(+)