[RFC,v2,0/2]

Message

H. Nikolaus Schaller Nov. 1, 2021, 9:39 a.m. UTC

RFC V2 2021-11-01 10:24:26:
* reworked to not misuse mmc_select_card() but add a call to
  mmc_fixup_device() right after where host->ops->init_card
  was called before to apply the wl1251 specific quirks.
  Device tree matching is done by a new table passed to mmc_fixup_device().
  suggested by: [e-mail]
  based on patches by: [e-mail]

RFC V1 2021-10-06 13:24:13:


H. Nikolaus Schaller (2):
  mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc
  mmc: host: omap_hsmmc: revert special init for wl1251

 drivers/mmc/core/card.h       | 19 ++++++++++++++++++
 drivers/mmc/core/mmc.c        |  1 +
 drivers/mmc/core/quirks.h     | 22 +++++++++++++++++++++
 drivers/mmc/core/sd.c         |  2 ++
 drivers/mmc/core/sdio.c       |  1 +
 drivers/mmc/host/omap_hsmmc.c | 36 -----------------------------------
 6 files changed, 45 insertions(+), 36 deletions(-)

Comments

Jérôme Pouiller Nov. 2, 2021, 11:14 a.m. UTC | #1

Hello Nikolaus,

On Monday 1 November 2021 10:39:10 CET H. Nikolaus Schaller wrote:
> 
> RFC V2 2021-11-01 10:24:26:
> * reworked to not misuse mmc_select_card() but add a call to
>   mmc_fixup_device() right after where host->ops->init_card
>   was called before to apply the wl1251 specific quirks.
>   Device tree matching is done by a new table passed to mmc_fixup_device().
>   suggested by: [e-mail]
>   based on patches by: [e-mail]

To make review easier, I think you can include these patches
in this series (BTW, I have no time to care of them until end
of next week. So, it will probably go faster if you take over
these patches).

(I also suggest to add a title to your series to make your work
easier to track.)

H. Nikolaus Schaller Nov. 2, 2021, 1:13 p.m. UTC | #2

Hi Jerome,

> Am 02.11.2021 um 12:14 schrieb Jérôme Pouiller <[e-mail]>:
> 
> Hello Nikolaus,
> 
> On Monday 1 November 2021 10:39:10 CET H. Nikolaus Schaller wrote:
>> 
>> RFC V2 2021-11-01 10:24:26:
>> * reworked to not misuse mmc_select_card() but add a call to
>>  mmc_fixup_device() right after where host->ops->init_card
>>  was called before to apply the wl1251 specific quirks.
>>  Device tree matching is done by a new table passed to mmc_fixup_device().
>>  suggested by: [e-mail]
>>  based on patches by: [e-mail]
> 
> To make review easier, I think you can include these patches
> in this series (BTW, I have no time to care of them until end
> of next week. So, it will probably go faster if you take over
> these patches).

Ok, no problem.

Now as I understand how it should be set up I could even propose
some new macro for discussion.

> 
> (I also suggest to add a title to your series to make your work
> easier to track.)

Yes... I didn't notice before I received my copy of this mail.
There is a missing if(strlen(subject) == 0) reject; in my helper
tool...

BR and thanks,
Nikolaus