| Message ID | 20210704181444.59396f6b@gecko.fritz.box (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | colo: Don't dump colo cache if dump-guest-core=off | expand |
Lukas Straub <lukasstraub2@web.de> wrote: > One might set dump-guest-core=off to make coredumps smaller and > still allow to debug many qemu bugs. Extend this option to the colo > cache. > > Signed-off-by: Lukas Straub <lukasstraub2@web.de> Reviewed-by: Juan Quintela <quintela@redhat.com>
diff --git a/migration/ram.c b/migration/ram.c index 723af67c2e..0797d0d222 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -56,6 +56,8 @@ #include "multifd.h" #include "sysemu/runstate.h" +#include "hw/boards.h" /* for machine_dump_guest_core() */ + #if defined(__linux__) #include "qemu/userfaultfd.h" #endif /* defined(__linux__) */ @@ -3356,6 +3358,10 @@ int colo_init_ram_cache(void) } return -errno; } + if (!machine_dump_guest_core(current_machine)) { + qemu_madvise(block->colo_cache, block->used_length, + QEMU_MADV_DONTDUMP); + } } }
One might set dump-guest-core=off to make coredumps smaller and still allow to debug many qemu bugs. Extend this option to the colo cache. Signed-off-by: Lukas Straub <lukasstraub2@web.de> --- migration/ram.c | 6 ++++++ 1 file changed, 6 insertions(+)