| Message ID | 20211102013636.177411-6-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kselftests/net: add missed tests to Makefile | expand |
On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@gmail.com> wrote: > > When generating the selftests to another folder, the toeplitz.sh > and toeplitz_client.sh are missing as they are not in Makefile, e.g. > > make -C tools/testing/selftests/ install \ > TARGETS="net" INSTALL_PATH=/tmp/kselftests > > Making them under TEST_PROGS_EXTENDED as they test NIC hardware features > and are not intended to be run from kselftests. > > Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test") > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Reviewed-by: Willem de Bruijn <willemb@google.com> The same might apply to the icmp and vrf tests? I am not familiar with those.
On Tue, Nov 02, 2021 at 11:09:43AM -0400, Willem de Bruijn wrote: > On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@gmail.com> wrote: > > > > When generating the selftests to another folder, the toeplitz.sh > > and toeplitz_client.sh are missing as they are not in Makefile, e.g. > > > > make -C tools/testing/selftests/ install \ > > TARGETS="net" INSTALL_PATH=/tmp/kselftests > > > > Making them under TEST_PROGS_EXTENDED as they test NIC hardware features > > and are not intended to be run from kselftests. > > > > Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test") > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > > Reviewed-by: Willem de Bruijn <willemb@google.com> Thanks for the review. > > The same might apply to the icmp and vrf tests? I am not familiar with those. icmp and vrf are running for selftests. They should be added to TEST_PROGS. Thanks Hangbin
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index 7328bede35f0..6a953ec793ce 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -33,6 +33,7 @@ TEST_PROGS += srv6_end_dt4_l3vpn_test.sh TEST_PROGS += srv6_end_dt6_l3vpn_test.sh TEST_PROGS += vrf_strict_mode_test.sh TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh +TEST_PROGS_EXTENDED += toeplitz_client.sh toeplitz.sh TEST_GEN_FILES = socket nettest TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite
When generating the selftests to another folder, the toeplitz.sh and toeplitz_client.sh are missing as they are not in Makefile, e.g. make -C tools/testing/selftests/ install \ TARGETS="net" INSTALL_PATH=/tmp/kselftests Making them under TEST_PROGS_EXTENDED as they test NIC hardware features and are not intended to be run from kselftests. Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- v2: move the tests under TEST_PROGS_EXTENDED as Willem suggested. --- tools/testing/selftests/net/Makefile | 1 + 1 file changed, 1 insertion(+)