| Message ID | 20211106003714.17894-1-radhakrishna.sripada@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Fix Memory BW formulae for ADL-P | expand |
Reviewed-by: Caz Yokoyama <caz.yokoyama@intel.com> -caz On Fri, 2021-11-05 at 17:37 -0700, Radhakrishna Sripada wrote: > The earlier update to BW formulae broke ADL-P. Include > GEN13 to use TGL path for BW parameters. > > Fixes: c64a9a7c05be drm/i915: Update memory bandwidth formulae > Cc: Matt Roper <matthew.d.roper@intel.com> > Reported-by: José Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > --- > drivers/gpu/drm/i915/display/intel_bw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c > b/drivers/gpu/drm/i915/display/intel_bw.c > index 15c006194c85..abec394f6869 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -147,7 +147,7 @@ static int icl_get_qgv_points(struct > drm_i915_private *dev_priv, > qi->num_points = dram_info->num_qgv_points; > qi->num_psf_points = dram_info->num_psf_gv_points; > > - if (DISPLAY_VER(dev_priv) == 12) > + if (DISPLAY_VER(dev_priv) >= 12) > switch (dram_info->type) { > case INTEL_DRAM_DDR4: > qi->t_bl = is_y_tile ? 8 : 4;
On Fri, 2021-11-05 at 17:37 -0700, Radhakrishna Sripada wrote: > The earlier update to BW formulae broke ADL-P. Include > GEN13 to use TGL path for BW parameters. include display 13. With that: Reviewed-by: José Roberto de Souza <jose.souza@intel.com> > > Fixes: c64a9a7c05be drm/i915: Update memory bandwidth formulae > Cc: Matt Roper <matthew.d.roper@intel.com> > Reported-by: José Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > --- > drivers/gpu/drm/i915/display/intel_bw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c > index 15c006194c85..abec394f6869 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -147,7 +147,7 @@ static int icl_get_qgv_points(struct drm_i915_private *dev_priv, > qi->num_points = dram_info->num_qgv_points; > qi->num_psf_points = dram_info->num_psf_gv_points; > > - if (DISPLAY_VER(dev_priv) == 12) > + if (DISPLAY_VER(dev_priv) >= 12) > switch (dram_info->type) { > case INTEL_DRAM_DDR4: > qi->t_bl = is_y_tile ? 8 : 4;
CI IGT reported some failures but they do not look to be related to the changes proposed.
Thanks,
Radhakrishna(RK) Sripada
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Friday, November 5, 2021 6:51 PM
To: Sripada, Radhakrishna <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✓ Fi.CI.BAT: success for drm/i915: Fix Memory BW formulae for ADL-P
Patch Details
Series:
drm/i915: Fix Memory BW formulae for ADL-P
URL:
https://patchwork.freedesktop.org/series/96635/
State:
success
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/index.html
CI Bug Log - changes from CI_DRM_10852 -> Patchwork_21530
Summary
SUCCESS
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/index.html
Participating hosts (40 -> 35)
Additional (3): fi-tgl-1115g4 fi-bdw-samus fi-tgl-u2
Missing (8): fi-kbl-soraka bat-adls-5 bat-dg1-6 bat-dg1-5 fi-hsw-4200u fi-bsw-cyan bat-adlp-4 fi-ctg-p8600
Known issues
Here are the changes found in Patchwork_21530 that come from known issues:
IGT changes
Issues hit
* igt@amdgpu/amd_basic@query-info:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html> (fdo#109315<https://bugs.freedesktop.org/show_bug.cgi?id=109315>)
* igt@amdgpu/amd_cs_nop@nop-gfx0:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html> (fdo#109315<https://bugs.freedesktop.org/show_bug.cgi?id=109315> / i915#2575<https://gitlab.freedesktop.org/drm/intel/issues/2575>) +16 similar issues
* igt@core_hotunplug@unbind-rebind:
* fi-tgl-u2: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html> (i915#4006<https://gitlab.freedesktop.org/drm/intel/issues/4006>)
* igt@gem_huc_copy@huc-copy:
* fi-tgl-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html> (i915#2190<https://gitlab.freedesktop.org/drm/intel/issues/2190>)
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html> (i915#2190<https://gitlab.freedesktop.org/drm/intel/issues/2190>)
* igt@i915_pm_backlight@basic-brightness:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html> (i915#1155<https://gitlab.freedesktop.org/drm/intel/issues/1155>)
* igt@kms_chamelium@common-hpd-after-suspend:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_chamelium@dp-hpd-fast:
* fi-tgl-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-u2/igt@kms_chamelium@dp-hpd-fast.html> (fdo#109284<https://bugs.freedesktop.org/show_bug.cgi?id=109284> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_chamelium@hdmi-edid-read:
* fi-bdw-samus: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-bdw-samus/igt@kms_chamelium@hdmi-edid-read.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
* fi-tgl-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#4103<https://gitlab.freedesktop.org/drm/intel/issues/4103>) +1 similar issue
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#4103<https://gitlab.freedesktop.org/drm/intel/issues/4103>) +1 similar issue
* igt@kms_force_connector_basic@force-load-detect:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
* fi-tgl-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
* fi-bdw-samus: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-bdw-samus/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +29 similar issues
* igt@kms_psr@primary_mmap_gtt:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) +3 similar issues
* igt@prime_vgem@basic-userptr:
* fi-tgl-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-u2/igt@prime_vgem@basic-userptr.html> (i915#3301<https://gitlab.freedesktop.org/drm/intel/issues/3301>)
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html> (i915#3301<https://gitlab.freedesktop.org/drm/intel/issues/3301>)
* igt@runner@aborted:
* fi-bdw-5557u: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-bdw-5557u/igt@runner@aborted.html> (i915#1602<https://gitlab.freedesktop.org/drm/intel/issues/1602> / i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)
* fi-tgl-u2: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/fi-tgl-u2/igt@runner@aborted.html> (i915#1602<https://gitlab.freedesktop.org/drm/intel/issues/1602> / i915#2722<https://gitlab.freedesktop.org/drm/intel/issues/2722> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)
Build changes
* Linux: CI_DRM_10852 -> Patchwork_21530
CI-20190529: 20190529
CI_DRM_10852: 81197989aafaf267c69805552cf415702eebd192 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6274: 569de51145fba197a8d93b2417348d47507bf485 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21530: 7df88b462d89454e26e647ac0918d037fbc3b02b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7df88b462d89 drm/i915: Fix Memory BW formulae for ADL-P
On Mon, 2021-11-08 at 22:46 +0000, Sripada, Radhakrishna wrote: > CI IGT reported some failures but they do not look to be related to the changes proposed. Pushed to drm-intel-next. > > Thanks, > Radhakrishna(RK) Sripada > > From: Patchwork <patchwork@emeril.freedesktop.org> > Sent: Friday, November 5, 2021 6:51 PM > To: Sripada, Radhakrishna <radhakrishna.sripada@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject:✓ Fi.CI.BAT: success for drm/i915: Fix Memory BW formulae for ADL-P > > Patch Details > Series: drm/i915: Fix Memory BW formulae for ADL-P URL: https://patchwork.freedesktop.org/series/96635/ State: success Details: https://intel-gfx- > ci.01.org/tree/drm-tip/Patchwork_21530/index.html CI Bug Log - changes from CI_DRM_10852 -> Patchwork_21530SummarySUCCESS > No regressions found. > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21530/index.html > Participating hosts (40 -> 35)Additional (3): fi-tgl-1115g4 fi-bdw-samus fi-tgl-u2 > Missing (8): fi-kbl-soraka bat-adls-5 bat-dg1-6 bat-dg1-5 fi-hsw-4200u fi-bsw-cyan bat-adlp-4 fi-ctg-p8600 > Known issuesHere are the changes found in Patchwork_21530 that come from known issues: > IGT changesIssues hit * igt@amdgpu/amd_basic@query-info: > - fi-tgl-1115g4: NOTRUN ->SKIP (fdo#109315) > * igt@amdgpu/amd_cs_nop@nop-gfx0: > - fi-tgl-1115g4: NOTRUN ->SKIP (fdo#109315 /i915#2575) +16 similar issues > * igt@core_hotunplug@unbind-rebind: > - fi-tgl-u2: NOTRUN ->INCOMPLETE (i915#4006) > * igt@gem_huc_copy@huc-copy: > - fi-tgl-u2: NOTRUN ->SKIP (i915#2190) > - fi-tgl-1115g4: NOTRUN ->SKIP (i915#2190) > * igt@i915_pm_backlight@basic-brightness: > - fi-tgl-1115g4: NOTRUN ->SKIP (i915#1155) > * igt@kms_chamelium@common-hpd-after-suspend: > - fi-tgl-1115g4: NOTRUN ->SKIP (fdo#111827) +8 similar issues > * igt@kms_chamelium@dp-hpd-fast: > - fi-tgl-u2: NOTRUN ->SKIP (fdo#109284 /fdo#111827) +8 similar issues > * igt@kms_chamelium@hdmi-edid-read: > - fi-bdw-samus: NOTRUN ->SKIP (fdo#109271 /fdo#111827) +8 similar issues > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: > - fi-tgl-u2: NOTRUN ->SKIP (i915#4103) +1 similar issue > - fi-tgl-1115g4: NOTRUN ->SKIP (i915#4103) +1 similar issue > * igt@kms_force_connector_basic@force-load-detect: > - fi-tgl-1115g4: NOTRUN ->SKIP (fdo#109285) > - fi-tgl-u2: NOTRUN ->SKIP (fdo#109285) > * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: > - fi-bdw-samus: NOTRUN ->SKIP (fdo#109271) +29 similar issues > * igt@kms_psr@primary_mmap_gtt: > - fi-tgl-1115g4: NOTRUN ->SKIP (i915#1072) +3 similar issues > * igt@prime_vgem@basic-userptr: > - fi-tgl-u2: NOTRUN ->SKIP (i915#3301) > - fi-tgl-1115g4: NOTRUN ->SKIP (i915#3301) > * igt@runner@aborted: > - fi-bdw-5557u: NOTRUN ->FAIL (i915#1602 /i915#2426 / i915#4312) > - fi-tgl-u2: NOTRUN ->FAIL (i915#1602 /i915#2722 / i915#4312) > Build changes * Linux: CI_DRM_10852 -> Patchwork_21530 > CI-20190529: 20190529 > CI_DRM_10852: 81197989aafaf267c69805552cf415702eebd192 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_6274: 569de51145fba197a8d93b2417348d47507bf485 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_21530: 7df88b462d89454e26e647ac0918d037fbc3b02b @ git://anongit.freedesktop.org/gfx-ci/linux > == Linux commits == > 7df88b462d89 drm/i915: Fix Memory BW formulae for ADL-P
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index 15c006194c85..abec394f6869 100644 --- a/drivers/gpu/drm/i915/display/intel_bw.c +++ b/drivers/gpu/drm/i915/display/intel_bw.c @@ -147,7 +147,7 @@ static int icl_get_qgv_points(struct drm_i915_private *dev_priv, qi->num_points = dram_info->num_qgv_points; qi->num_psf_points = dram_info->num_psf_gv_points; - if (DISPLAY_VER(dev_priv) == 12) + if (DISPLAY_VER(dev_priv) >= 12) switch (dram_info->type) { case INTEL_DRAM_DDR4: qi->t_bl = is_y_tile ? 8 : 4;
The earlier update to BW formulae broke ADL-P. Include GEN13 to use TGL path for BW parameters. Fixes: c64a9a7c05be drm/i915: Update memory bandwidth formulae Cc: Matt Roper <matthew.d.roper@intel.com> Reported-by: José Roberto de Souza <jose.souza@intel.com> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> --- drivers/gpu/drm/i915/display/intel_bw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)