| Message ID | 1a4b790b-8074-1f67-24f5-662400b2976e@kernel.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: use enum type for blk_mq_alloc_data->rq_flags | expand |
On 11/9/21 2:10 PM, Jens Axboe wrote: > kernel test robot reports that we now trigger some sparse warnings: > > block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer > block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer > block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer > > which is due to ->rq_flags being an unsigned int, rather than the > stronger type req_flags_t enum. > > Change the type to req_flags_t to silence this warning. Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On 11/9/2021 2:10 PM, Jens Axboe wrote: > External email: Use caution opening links or attachments > > > kernel test robot reports that we now trigger some sparse warnings: > > block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer > block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer > block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer > > which is due to ->rq_flags being an unsigned int, rather than the > stronger type req_flags_t enum. > > Change the type to req_flags_t to silence this warning. > > Fixes: 56f8da642bd8 ("block: add rq_flags to struct blk_mq_alloc_data") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
diff --git a/block/blk-mq.h b/block/blk-mq.h index cb0b5482ca5e..39370bbdf3b6 100644 --- a/block/blk-mq.h +++ b/block/blk-mq.h @@ -149,7 +149,7 @@ struct blk_mq_alloc_data { blk_mq_req_flags_t flags; unsigned int shallow_depth; unsigned int cmd_flags; - unsigned int rq_flags; + req_flags_t rq_flags; /* allocate multiple requests/tags in one go */ unsigned int nr_tags;
kernel test robot reports that we now trigger some sparse warnings: block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer block/blk-mq.h:169:32: sparse: sparse: restricted req_flags_t degrades to integer which is due to ->rq_flags being an unsigned int, rather than the stronger type req_flags_t enum. Change the type to req_flags_t to silence this warning. Fixes: 56f8da642bd8 ("block: add rq_flags to struct blk_mq_alloc_data") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> ---