| Message ID | 20211110191610.5664-8-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk/mmc: renesas_sdhi: refactor SDnH to be a separate clock | expand |
On Wed, 10 Nov 2021 at 20:16, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > Changes since RFC v1: > * use 'oneOf' for the clock-names > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > index 9f1e7092cf44..190a58ae77b5 100644 > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > @@ -132,12 +132,20 @@ allOf: > properties: > clocks: > minItems: 1 > - maxItems: 2 > + maxItems: 3 > clock-names: > - minItems: 1 > - items: > + oneOf: > - const: core > - - const: cd > + - items: > + - const: core > + - const: cd > + - items: > + - const: core > + - const: clkh > + - items: > + - const: core > + - const: clkh > + - const: cd > > - if: > properties: > -- > 2.30.2 >
Hi Wolfram, CC devicetree On Wed, Nov 10, 2021 at 8:16 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Changes since RFC v1: > * use 'oneOf' for the clock-names Thanks for the update! > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > @@ -132,12 +132,20 @@ allOf: > properties: > clocks: > minItems: 1 > - maxItems: 2 > + maxItems: 3 > clock-names: > - minItems: 1 > - items: > + oneOf: > - const: core > - - const: cd > + - items: > + - const: core > + - const: cd > + - items: > + - const: core > + - const: clkh > + - items: > + - const: core > + - const: clkh > + - const: cd That can be simplified to: clock-names: minItems: 1 maxItems: 3 uniqueItems: true items: - const: core - enum: [ clkh, cd ] - const: cd But shouldn't the clkh case be restricted to "renesas,rcar-gen3-sdhi"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, > That can be simplified to: > > clock-names: > minItems: 1 > maxItems: 3 > uniqueItems: true > items: > - const: core > - enum: [ clkh, cd ] > - const: cd OK, nice. > But shouldn't the clkh case be restricted to "renesas,rcar-gen3-sdhi"? I don't think so because I assume all following generations will have clkh as well. All the best, Wolfram
Hi Wolfram, On Fri, Nov 12, 2021 at 12:57 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > That can be simplified to: > > > > clock-names: > > minItems: 1 > > maxItems: 3 > > uniqueItems: true > > items: > > - const: core > > - enum: [ clkh, cd ] > > - const: cd > > OK, nice. > > > But shouldn't the clkh case be restricted to "renesas,rcar-gen3-sdhi"? > > I don't think so because I assume all following generations will have > clkh as well. My issue is that the _previous_ generations (e.g. SH/R-Mobile and RZ/A[12]) do not have it. R-Car Gen2 has SDH clocks and the clock driver implements them, but they are always disabled, as there are no users. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml index 9f1e7092cf44..190a58ae77b5 100644 --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml @@ -132,12 +132,20 @@ allOf: properties: clocks: minItems: 1 - maxItems: 2 + maxItems: 3 clock-names: - minItems: 1 - items: + oneOf: - const: core - - const: cd + - items: + - const: core + - const: cd + - items: + - const: core + - const: clkh + - items: + - const: core + - const: clkh + - const: cd - if: properties:
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Changes since RFC v1: * use 'oneOf' for the clock-names .../devicetree/bindings/mmc/renesas,sdhi.yaml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)