mbox series

[net,0/2] net: fix the mirred packet drop due to the incorrect dst

Message ID cover.1636734751.git.lucien.xin@gmail.com (mailing list archive)
Headers show
Series net: fix the mirred packet drop due to the incorrect dst | expand

Message

Xin Long Nov. 12, 2021, 4:33 p.m. UTC
This issue was found when using OVS HWOL on OVN-k8s. These packets
dropped on rx path were seen with output dst, which should've been
dropped from the skbs when redirecting them.

The 1st patch is to the fix and the 2nd is a selftest to reproduce
and verify it.

Davide Caratti (1):
  selftests: add a test case for mirred egress to ingress

Xin Long (1):
  net: sched: act_mirred: drop dst for the direction from egress to
    ingress

 net/sched/act_mirred.c                        | 11 +++--
 tools/testing/selftests/net/forwarding/config |  1 +
 .../selftests/net/forwarding/tc_actions.sh    | 47 ++++++++++++++++++-
 3 files changed, 55 insertions(+), 4 deletions(-)

Comments

Xin Long Nov. 12, 2021, 4:34 p.m. UTC | #1
+Cc Davide.

On Fri, Nov 12, 2021 at 11:33 AM Xin Long <lucien.xin@gmail.com> wrote:
>
> This issue was found when using OVS HWOL on OVN-k8s. These packets
> dropped on rx path were seen with output dst, which should've been
> dropped from the skbs when redirecting them.
>
> The 1st patch is to the fix and the 2nd is a selftest to reproduce
> and verify it.
>
> Davide Caratti (1):
>   selftests: add a test case for mirred egress to ingress
>
> Xin Long (1):
>   net: sched: act_mirred: drop dst for the direction from egress to
>     ingress
>
>  net/sched/act_mirred.c                        | 11 +++--
>  tools/testing/selftests/net/forwarding/config |  1 +
>  .../selftests/net/forwarding/tc_actions.sh    | 47 ++++++++++++++++++-
>  3 files changed, 55 insertions(+), 4 deletions(-)
>
> --
> 2.27.0
>
Cong Wang Nov. 15, 2021, 5:05 a.m. UTC | #2
On Fri, Nov 12, 2021 at 8:33 AM Xin Long <lucien.xin@gmail.com> wrote:
>
> This issue was found when using OVS HWOL on OVN-k8s. These packets
> dropped on rx path were seen with output dst, which should've been
> dropped from the skbs when redirecting them.
>
> The 1st patch is to the fix and the 2nd is a selftest to reproduce
> and verify it.

Acked-by: Cong Wang <cong.wang@bytedance.com>

Thanks.
Marcelo Ricardo Leitner Nov. 16, 2021, 3:55 p.m. UTC | #3
On Fri, Nov 12, 2021 at 11:33:10AM -0500, Xin Long wrote:
> This issue was found when using OVS HWOL on OVN-k8s. These packets
> dropped on rx path were seen with output dst, which should've been
> dropped from the skbs when redirecting them.
>
> The 1st patch is to the fix and the 2nd is a selftest to reproduce
> and verify it.

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Jakub Kicinski Nov. 17, 2021, 3:42 a.m. UTC | #4
On Fri, 12 Nov 2021 11:33:10 -0500 Xin Long wrote:
> This issue was found when using OVS HWOL on OVN-k8s. These packets
> dropped on rx path were seen with output dst, which should've been
> dropped from the skbs when redirecting them.
> 
> The 1st patch is to the fix and the 2nd is a selftest to reproduce
> and verify it.

Applied, thanks!