mbox series

[0/3] selftests: gpio: fix minor build issues

Message ID 20211108012851.7772-1-warthog618@gmail.com (mailing list archive)
Headers show
Series selftests: gpio: fix minor build issues | expand

Message

Kent Gibson Nov. 8, 2021, 1:28 a.m. UTC 
This is a series of fixes for minor problems in the building of the GPIO
selftests introduced by my rework of those tests.

The first patch is from Li Zhijian and fixes a compiler error when
building the selftests in environments with stale system includes.
I have reworded the commit comment to make it more to the point in
describing the root cause of the problem and the fix, as suggested by
Shuah in his initial review of that patch.

The second patch fixes a warning when the tests are compiled with -Wall,
and the final patch restores the CFLAGS that should not have been removed
in the rework, including the -Wall.

Kent Gibson (2):
  selftests: gpio: fix uninitialised variable warning
  selftests: gpio: restore CFLAGS options

Li Zhijian (1):
  selftests: gpio: fix gpio compiling error

 tools/testing/selftests/gpio/Makefile           | 1 +
 tools/testing/selftests/gpio/gpio-mockup-cdev.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Bartosz Golaszewski Nov. 15, 2021, 1:28 p.m. UTC | #1 
On Mon, Nov 8, 2021 at 2:29 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> This is a series of fixes for minor problems in the building of the GPIO
> selftests introduced by my rework of those tests.
>
> The first patch is from Li Zhijian and fixes a compiler error when
> building the selftests in environments with stale system includes.
> I have reworded the commit comment to make it more to the point in
> describing the root cause of the problem and the fix, as suggested by
> Shuah in his initial review of that patch.
>
> The second patch fixes a warning when the tests are compiled with -Wall,
> and the final patch restores the CFLAGS that should not have been removed
> in the rework, including the -Wall.
>
> Kent Gibson (2):
>   selftests: gpio: fix uninitialised variable warning
>   selftests: gpio: restore CFLAGS options
>
> Li Zhijian (1):
>   selftests: gpio: fix gpio compiling error
>
>  tools/testing/selftests/gpio/Makefile           | 1 +
>  tools/testing/selftests/gpio/gpio-mockup-cdev.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> --
> 2.33.1
>

Queued for fixes, thanks!

Bart