| Message ID | 20211115141925.60164-4-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: buffer-dma: write() and new DMABUF based API | expand |
On Mon, Nov 15, 2021 at 4:19 PM Paul Cercueil <paul@crapouillou.net> wrote: > > We know that the buffer's alignment will always be a power of two; > therefore, we can use the faster round_down() macro. > Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > index 1ac94c4e9792..f8ce26a24c57 100644 > --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c > +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > @@ -67,7 +67,7 @@ static int iio_dmaengine_buffer_submit_block(struct iio_dma_buffer_queue *queue, > dma_cookie_t cookie; > > block->bytes_used = min(block->size, dmaengine_buffer->max_size); > - block->bytes_used = rounddown(block->bytes_used, > + block->bytes_used = round_down(block->bytes_used, > dmaengine_buffer->align); > > desc = dmaengine_prep_slave_single(dmaengine_buffer->chan, > -- > 2.33.0 >
On Mon, 15 Nov 2021 14:19:13 +0000 Paul Cercueil <paul@crapouillou.net> wrote: > We know that the buffer's alignment will always be a power of two; > therefore, we can use the faster round_down() macro. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> *groan*. I don't want to know where the naming of these two came from but that is spectacular... Anyhow, happy to pick up 1-3 now if you like as all are good cleanup of existing code. Jonathan > --- > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > index 1ac94c4e9792..f8ce26a24c57 100644 > --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c > +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > @@ -67,7 +67,7 @@ static int iio_dmaengine_buffer_submit_block(struct iio_dma_buffer_queue *queue, > dma_cookie_t cookie; > > block->bytes_used = min(block->size, dmaengine_buffer->max_size); > - block->bytes_used = rounddown(block->bytes_used, > + block->bytes_used = round_down(block->bytes_used, > dmaengine_buffer->align); > > desc = dmaengine_prep_slave_single(dmaengine_buffer->chan,
Hi Jonathan, Le dim., nov. 21 2021 at 14:08:23 +0000, Jonathan Cameron <jic23@kernel.org> a écrit : > On Mon, 15 Nov 2021 14:19:13 +0000 > Paul Cercueil <paul@crapouillou.net> wrote: > >> We know that the buffer's alignment will always be a power of two; >> therefore, we can use the faster round_down() macro. >> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net> > *groan*. I don't want to know where the naming of these two came > from but that > is spectacular... > > Anyhow, happy to pick up 1-3 now if you like as all are good cleanup > of > existing code. I think you can pick 2-3 now; I will do some changes to patch [01/15] in the V2. Cheers, -Paul
On Mon, 22 Nov 2021 10:00:19 +0000 Paul Cercueil <paul@crapouillou.net> wrote: > Hi Jonathan, > > Le dim., nov. 21 2021 at 14:08:23 +0000, Jonathan Cameron > <jic23@kernel.org> a écrit : > > On Mon, 15 Nov 2021 14:19:13 +0000 > > Paul Cercueil <paul@crapouillou.net> wrote: > > > >> We know that the buffer's alignment will always be a power of two; > >> therefore, we can use the faster round_down() macro. > >> > >> Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > *groan*. I don't want to know where the naming of these two came > > from but that > > is spectacular... > > > > Anyhow, happy to pick up 1-3 now if you like as all are good cleanup > > of > > existing code. > > I think you can pick 2-3 now; I will do some changes to patch [01/15] > in the V2. Applied, 2+3 to the togreg branch of iio.git and pushed out as testing for all the normal reasons. Thanks, Jonathan > > Cheers, > -Paul > >
diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c index 1ac94c4e9792..f8ce26a24c57 100644 --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c @@ -67,7 +67,7 @@ static int iio_dmaengine_buffer_submit_block(struct iio_dma_buffer_queue *queue, dma_cookie_t cookie; block->bytes_used = min(block->size, dmaengine_buffer->max_size); - block->bytes_used = rounddown(block->bytes_used, + block->bytes_used = round_down(block->bytes_used, dmaengine_buffer->align); desc = dmaengine_prep_slave_single(dmaengine_buffer->chan,
We know that the buffer's alignment will always be a power of two; therefore, we can use the faster round_down() macro. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)