| Message ID | 20211117151450.207168-2-marcan@marcan.st (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: tipd: Fixes for Apple M1 (CD321X) support | expand |
On Thu, Nov 18, 2021 at 12:14:49AM +0900, Hector Martin wrote: > SPSS should've been SSPS. > > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > drivers/usb/typec/tipd/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index fb8ef12bbe9c..4da5a0b2aed2 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -653,7 +653,7 @@ static int cd321x_switch_power_state(struct tps6598x *tps, u8 target_state) > if (state == target_state) > return 0; > > - ret = tps6598x_exec_cmd(tps, "SPSS", sizeof(u8), &target_state, 0, NULL); > + ret = tps6598x_exec_cmd(tps, "SSPS", sizeof(u8), &target_state, 0, NULL); > if (ret) > return ret; > > -- > 2.33.0 > This looks like a "Fix" commit. What commit id does this fix? thanks, greg k-h
On 18/11/2021 01.03, Greg Kroah-Hartman wrote: > On Thu, Nov 18, 2021 at 12:14:49AM +0900, Hector Martin wrote: >> SPSS should've been SSPS. >> >> Signed-off-by: Hector Martin <marcan@marcan.st> >> --- >> drivers/usb/typec/tipd/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c >> index fb8ef12bbe9c..4da5a0b2aed2 100644 >> --- a/drivers/usb/typec/tipd/core.c >> +++ b/drivers/usb/typec/tipd/core.c >> @@ -653,7 +653,7 @@ static int cd321x_switch_power_state(struct tps6598x *tps, u8 target_state) >> if (state == target_state) >> return 0; >> >> - ret = tps6598x_exec_cmd(tps, "SPSS", sizeof(u8), &target_state, 0, NULL); >> + ret = tps6598x_exec_cmd(tps, "SSPS", sizeof(u8), &target_state, 0, NULL); >> if (ret) >> return ret; >> >> -- >> 2.33.0 >> > > This looks like a "Fix" commit. What commit id does this fix? > > thanks, > > greg k-h > That should be: Fixes: c9c14be664cf ("usb: typec: tipd: Switch CD321X power state to S0") Thanks,
On Thu, Nov 18, 2021 at 12:14:49AM +0900, Hector Martin wrote: > SPSS should've been SSPS. > > Signed-off-by: Hector Martin <marcan@marcan.st> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tipd/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index fb8ef12bbe9c..4da5a0b2aed2 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -653,7 +653,7 @@ static int cd321x_switch_power_state(struct tps6598x *tps, u8 target_state) > if (state == target_state) > return 0; > > - ret = tps6598x_exec_cmd(tps, "SPSS", sizeof(u8), &target_state, 0, NULL); > + ret = tps6598x_exec_cmd(tps, "SSPS", sizeof(u8), &target_state, 0, NULL); > if (ret) > return ret; > > -- > 2.33.0
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index fb8ef12bbe9c..4da5a0b2aed2 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -653,7 +653,7 @@ static int cd321x_switch_power_state(struct tps6598x *tps, u8 target_state) if (state == target_state) return 0; - ret = tps6598x_exec_cmd(tps, "SPSS", sizeof(u8), &target_state, 0, NULL); + ret = tps6598x_exec_cmd(tps, "SSPS", sizeof(u8), &target_state, 0, NULL); if (ret) return ret;
SPSS should've been SSPS. Signed-off-by: Hector Martin <marcan@marcan.st> --- drivers/usb/typec/tipd/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)