diff mbox series

[1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-P

Message ID 20211119063128.67366-2-madhumitha.tolakanahalli.pradeep@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-P | expand

Commit Message

Tolakanahalli Pradeep, Madhumitha Nov. 19, 2021, 6:31 a.m. UTC
The release notes mention that DMC v2.14 provides -
 1. Fix for Flip queue roll over cases with DC6v
 2. Enhancement for residency
 3. Workaround for 3Dlut restore issue

Signed-off-by: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Imre Deak Nov. 19, 2021, 12:58 p.m. UTC | #1
On Thu, Nov 18, 2021 at 10:31:28PM -0800, Madhumitha Tolakanahalli Pradeep wrote:
> The release notes mention that DMC v2.14 provides -
>  1. Fix for Flip queue roll over cases with DC6v
>  2. Enhancement for residency
>  3. Workaround for 3Dlut restore issue

Could you also add the 2.12 -> 2.13 release notes?

> Signed-off-by: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 2dc9d632969d..8617cd1ec9b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -45,8 +45,8 @@
>  
>  #define GEN12_DMC_MAX_FW_SIZE		ICL_DMC_MAX_FW_SIZE
>  
> -#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 12)
> -#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 12)
> +#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 14)
> +#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 14)
>  MODULE_FIRMWARE(ADLP_DMC_PATH);
>  
>  #define ADLS_DMC_PATH			DMC_PATH(adls, 2, 01)
> -- 
> 2.33.1
>
Srivatsa, Anusha Nov. 19, 2021, 3:03 p.m. UTC | #2
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Madhumitha Tolakanahalli Pradeep
> Sent: Thursday, November 18, 2021 10:31 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-
> P
> 
> The release notes mention that DMC v2.14 provides -  1. Fix for Flip queue
> roll over cases with DC6v  2. Enhancement for residency  3. Workaround for
> 3Dlut restore issue
> 
> Signed-off-by: Madhumitha Tolakanahalli Pradeep
> <madhumitha.tolakanahalli.pradeep@intel.com>

Thanks for the patch.

Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 2dc9d632969d..8617cd1ec9b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -45,8 +45,8 @@
> 
>  #define GEN12_DMC_MAX_FW_SIZE		ICL_DMC_MAX_FW_SIZE
> 
> -#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 12)
> -#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 12)
> +#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 14)
> +#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 14)
>  MODULE_FIRMWARE(ADLP_DMC_PATH);
> 
>  #define ADLS_DMC_PATH			DMC_PATH(adls, 2, 01)
> --
> 2.33.1
Srivatsa, Anusha Nov. 19, 2021, 3:06 p.m. UTC | #3
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Imre
> Deak
> Sent: Friday, November 19, 2021 4:58 AM
> To: Tolakanahalli Pradeep, Madhumitha
> <madhumitha.tolakanahalli.pradeep@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to v2.14 on
> ADL-P
> 
> On Thu, Nov 18, 2021 at 10:31:28PM -0800, Madhumitha Tolakanahalli
> Pradeep wrote:
> > The release notes mention that DMC v2.14 provides -  1. Fix for Flip
> > queue roll over cases with DC6v  2. Enhancement for residency  3.
> > Workaround for 3Dlut restore issue
> 
> Could you also add the 2.12 -> 2.13 release notes?

Oops saw Imre's comment now. 
@Tolakanahalli Pradeep, Madhumitha Please do the needful.

Anusha 
> > Signed-off-by: Madhumitha Tolakanahalli Pradeep
> > <madhumitha.tolakanahalli.pradeep@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> > b/drivers/gpu/drm/i915/display/intel_dmc.c
> > index 2dc9d632969d..8617cd1ec9b2 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> > @@ -45,8 +45,8 @@
> >
> >  #define GEN12_DMC_MAX_FW_SIZE		ICL_DMC_MAX_FW_SIZE
> >
> > -#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 12)
> > -#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 12)
> > +#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 14)
> > +#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 14)
> >  MODULE_FIRMWARE(ADLP_DMC_PATH);
> >
> >  #define ADLS_DMC_PATH			DMC_PATH(adls, 2, 01)
> > --
> > 2.33.1
> >
Tolakanahalli Pradeep, Madhumitha Nov. 19, 2021, 3:45 p.m. UTC | #4
On Fri, 2021-11-19 at 15:06 +0000, Srivatsa, Anusha wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf
> > Of Imre
> > Deak
> > Sent: Friday, November 19, 2021 4:58 AM
> > To: Tolakanahalli Pradeep, Madhumitha
> > <madhumitha.tolakanahalli.pradeep@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to
> > v2.14 on
> > ADL-P
> > 
> > On Thu, Nov 18, 2021 at 10:31:28PM -0800, Madhumitha Tolakanahalli
> > Pradeep wrote:
> > > The release notes mention that DMC v2.14 provides -  1. Fix for
> > > Flip
> > > queue roll over cases with DC6v  2. Enhancement for residency  3.
> > > Workaround for 3Dlut restore issue
> > 
> > Could you also add the 2.12 -> 2.13 release notes?
> 
> Oops saw Imre's comment now.
> @Tolakanahalli Pradeep, Madhumitha Please do the needful.
> 
> Anusha

Thanks Imre and Anusha! I'll update the release notes and send out 
the next version.

- Madhumitha

> > > Signed-off-by: Madhumitha Tolakanahalli Pradeep
> > > <madhumitha.tolakanahalli.pradeep@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> > > b/drivers/gpu/drm/i915/display/intel_dmc.c
> > > index 2dc9d632969d..8617cd1ec9b2 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> > > @@ -45,8 +45,8 @@
> > > 
> > >  #define GEN12_DMC_MAX_FW_SIZEICL_DMC_MAX_FW_SIZE
> > > 
> > > -#define ADLP_DMC_PATHDMC_PATH(adlp, 2, 12)
> > > -#define ADLP_DMC_VERSION_REQUIREDDMC_VERSION(2, 12)
> > > +#define ADLP_DMC_PATHDMC_PATH(adlp, 2, 14)
> > > +#define ADLP_DMC_VERSION_REQUIREDDMC_VERSION(2, 14)
> > >  MODULE_FIRMWARE(ADLP_DMC_PATH);
> > > 
> > >  #define ADLS_DMC_PATHDMC_PATH(adls, 2, 01)
> > > --
> > > 2.33.1
> > >
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 2dc9d632969d..8617cd1ec9b2 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -45,8 +45,8 @@ 
 
 #define GEN12_DMC_MAX_FW_SIZE		ICL_DMC_MAX_FW_SIZE
 
-#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 12)
-#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 12)
+#define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 14)
+#define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 14)
 MODULE_FIRMWARE(ADLP_DMC_PATH);
 
 #define ADLS_DMC_PATH			DMC_PATH(adls, 2, 01)