| Message ID | 20211117103850.28397-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: renesas_sdhi: simplify an expression | expand |
Hi Wolfram, Nice fix. On 2021-11-17 11:38:50 +0100, Wolfram Sang wrote: > We already have 'quirks', no need to go via 'priv'. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index a4407f391f66..29bc086f6cb5 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -1044,7 +1044,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, > host->mmc->caps2 & (MMC_CAP2_HS200_1_8V_SDR | > MMC_CAP2_HS400_1_8V))) { > const struct renesas_sdhi_scc *taps = of_data->taps; > - bool use_4tap = priv->quirks && priv->quirks->hs400_4taps; > + bool use_4tap = quirks && quirks->hs400_4taps; > bool hit = false; > > for (i = 0; i < of_data->taps_num; i++) { > -- > 2.30.2 >
On Wed, Nov 17, 2021 at 1:21 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > We already have 'quirks', no need to go via 'priv'. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, 17 Nov 2021 at 11:38, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > We already have 'quirks', no need to go via 'priv'. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index a4407f391f66..29bc086f6cb5 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -1044,7 +1044,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, > host->mmc->caps2 & (MMC_CAP2_HS200_1_8V_SDR | > MMC_CAP2_HS400_1_8V))) { > const struct renesas_sdhi_scc *taps = of_data->taps; > - bool use_4tap = priv->quirks && priv->quirks->hs400_4taps; > + bool use_4tap = quirks && quirks->hs400_4taps; > bool hit = false; > > for (i = 0; i < of_data->taps_num; i++) { > -- > 2.30.2 >
On Mon, Nov 22, 2021 at 12:38 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > On Wed, 17 Nov 2021 at 11:38, Wolfram Sang > <wsa+renesas@sang-engineering.com> wrote: > > > > We already have 'quirks', no need to go via 'priv'. > > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Thanks, will queue in renesas-clk-for-v5.17 with the other MMC patches. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index a4407f391f66..29bc086f6cb5 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -1044,7 +1044,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, host->mmc->caps2 & (MMC_CAP2_HS200_1_8V_SDR | MMC_CAP2_HS400_1_8V))) { const struct renesas_sdhi_scc *taps = of_data->taps; - bool use_4tap = priv->quirks && priv->quirks->hs400_4taps; + bool use_4tap = quirks && quirks->hs400_4taps; bool hit = false; for (i = 0; i < of_data->taps_num; i++) {
We already have 'quirks', no need to go via 'priv'. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/mmc/host/renesas_sdhi_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)