mbox series

[PATCH-for-6.2?,0/2] hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector

Message ID 20211115223619.2599282-1-philmd@redhat.com (mailing list archive)
Headers show
Series hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector | expand

Message

Philippe Mathieu-Daudé Nov. 15, 2021, 10:36 p.m. UTC 
The GICv3 ITS support has been introduced uring the 6.2 development
window (commits 18f6290a6a9..17fb5e36aab). This device is for
emulation. When building virtualization-only binary, it might be
desirable to not include this device.

Introduce the CONFIG_ARM_GIC_TCG Kconfig selector to allow downstream
distributions to deselect this device.

Based-on: pull-target-arm-20211115-1

Philippe Mathieu-Daudé (2):
  hw/intc/arm_gicv3: Extract gicv3_set_gicv3state from arm_gicv3_cpuif.c
  hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector

 hw/intc/arm_gicv3.c              |  2 +-
 hw/intc/arm_gicv3_cpuif.c        | 10 +---------
 hw/intc/arm_gicv3_cpuif_common.c | 22 ++++++++++++++++++++++
 hw/intc/Kconfig                  |  5 +++++
 hw/intc/meson.build              | 11 +++++++----
 5 files changed, 36 insertions(+), 14 deletions(-)
 create mode 100644 hw/intc/arm_gicv3_cpuif_common.c

Comments

Peter Maydell Nov. 22, 2021, 10:59 a.m. UTC | #1 
On Mon, 15 Nov 2021 at 22:36, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The GICv3 ITS support has been introduced uring the 6.2 development
> window (commits 18f6290a6a9..17fb5e36aab). This device is for
> emulation. When building virtualization-only binary, it might be
> desirable to not include this device.
>
> Introduce the CONFIG_ARM_GIC_TCG Kconfig selector to allow downstream
> distributions to deselect this device.
>
> Based-on: pull-target-arm-20211115-1
>
> Philippe Mathieu-Daudé (2):
>   hw/intc/arm_gicv3: Extract gicv3_set_gicv3state from arm_gicv3_cpuif.c
>   hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

This looks OK to me, but I'm inclined to leave it for 7.0 at this
point in the release cycle, unless it would be awkward for
downstreams if we didn't put it in ?

thanks
-- PMM
Philippe Mathieu-Daudé Nov. 22, 2021, 12:04 p.m. UTC | #2 
On 11/22/21 11:59, Peter Maydell wrote:
> On Mon, 15 Nov 2021 at 22:36, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> The GICv3 ITS support has been introduced uring the 6.2 development
>> window (commits 18f6290a6a9..17fb5e36aab). This device is for
>> emulation. When building virtualization-only binary, it might be
>> desirable to not include this device.
>>
>> Introduce the CONFIG_ARM_GIC_TCG Kconfig selector to allow downstream
>> distributions to deselect this device.
>>
>> Based-on: pull-target-arm-20211115-1
>>
>> Philippe Mathieu-Daudé (2):
>>   hw/intc/arm_gicv3: Extract gicv3_set_gicv3state from arm_gicv3_cpuif.c
>>   hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> This looks OK to me, but I'm inclined to leave it for 7.0 at this
> point in the release cycle, unless it would be awkward for
> downstreams if we didn't put it in ?

Mirek was Cc'ed and didn't comment so let's delay it to 7.0.