mbox series

[v5,00/17] Extensions to ov8865 driver

Message ID 20211123000017.43187-1-djrscally@gmail.com (mailing list archive)
Headers show
Series Extensions to ov8865 driver | expand

Message

Daniel Scally Nov. 23, 2021, midnight UTC
Hello all

This series extends the ov8865 driver with:

* Support for binding to ACPI enumerated devices.
* Support for a 19.2MHz clock in addition to existing 24MHz clock support
* Another v4l2_subdev_pad_ops callback
* 4 more V4L2 controls
* makes the driver supported by the cio2-bridge

There's also a little bit of tidying that I did along the way.

The series is tested on an MS Surface Go 2.

Thanks
Dan

Series level changes since v4:

	- Moved the two patches fixing issues to the head of the series and
	added Fixes tags
	- Added a new patch fixing the maximum gain value

Daniel Scally (16):
  media: i2c: Re-order runtime pm initialisation
  media: i2c: Add ACPI support to ov8865
  media: i2c: Fix incorrect value in comment
  media: i2c: Defer probe if not endpoint found
  media: i2c: Support 19.2MHz input clock in ov8865
  media: i2c: Add .get_selection() support to ov8865
  media: i2c: Switch control to V4L2_CID_ANALOGUE_GAIN
  media: i2c: Add vblank control to ov8865
  media: i2c: Add hblank control to ov8865
  media: i2c: Update HTS values in ov8865
  media: i2c: cap exposure at height + vblank in ov8865
  media: i2c: Add controls from fwnode to ov8865
  media: i2c: Switch exposure control unit to lines
  media: i2c: Use dev_err_probe() in ov8865
  media: i2c: Fix max gain in ov8865
  media: ipu3-cio2: Add INT347A to cio2-bridge

Hans de Goede (1):
  media: i2c: ov8865: Fix lockdep error

 drivers/media/i2c/ov8865.c                 | 466 +++++++++++++++------
 drivers/media/pci/intel/ipu3/cio2-bridge.c |   2 +
 2 files changed, 334 insertions(+), 134 deletions(-)

Comments

Sakari Ailus Nov. 23, 2021, 10:47 a.m. UTC | #1
On Tue, Nov 23, 2021 at 12:00:00AM +0000, Daniel Scally wrote:
> Hello all
> 
> This series extends the ov8865 driver with:
> 
> * Support for binding to ACPI enumerated devices.
> * Support for a 19.2MHz clock in addition to existing 24MHz clock support
> * Another v4l2_subdev_pad_ops callback
> * 4 more V4L2 controls
> * makes the driver supported by the cio2-bridge
> 
> There's also a little bit of tidying that I did along the way.
> 
> The series is tested on an MS Surface Go 2.

Nice patches.

Thanks, Daniel!
Daniel Scally Nov. 23, 2021, 12:10 p.m. UTC | #2
On 23/11/2021 10:47, Sakari Ailus wrote:
> On Tue, Nov 23, 2021 at 12:00:00AM +0000, Daniel Scally wrote:
>> Hello all
>>
>> This series extends the ov8865 driver with:
>>
>> * Support for binding to ACPI enumerated devices.
>> * Support for a 19.2MHz clock in addition to existing 24MHz clock support
>> * Another v4l2_subdev_pad_ops callback
>> * 4 more V4L2 controls
>> * makes the driver supported by the cio2-bridge
>>
>> There's also a little bit of tidying that I did along the way.
>>
>> The series is tested on an MS Surface Go 2.
> Nice patches.
>
> Thanks, Daniel!
>
Thank you :)
Hans de Goede Nov. 25, 2021, 8:37 p.m. UTC | #3
Hi,

On 11/23/21 01:00, Daniel Scally wrote:
> Hello all
> 
> This series extends the ov8865 driver with:
> 
> * Support for binding to ACPI enumerated devices.
> * Support for a 19.2MHz clock in addition to existing 24MHz clock support
> * Another v4l2_subdev_pad_ops callback
> * 4 more V4L2 controls
> * makes the driver supported by the cio2-bridge
> 
> There's also a little bit of tidying that I did along the way.
> 
> The series is tested on an MS Surface Go 2.


Thank you.

The patches look good to me and I've tested this series on a Microsoft Surface
Go (version 1) and everything works as it should:

Acked-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans




> Series level changes since v4:
> 
> 	- Moved the two patches fixing issues to the head of the series and
> 	added Fixes tags
> 	- Added a new patch fixing the maximum gain value
> 
> Daniel Scally (16):
>   media: i2c: Re-order runtime pm initialisation
>   media: i2c: Add ACPI support to ov8865
>   media: i2c: Fix incorrect value in comment
>   media: i2c: Defer probe if not endpoint found
>   media: i2c: Support 19.2MHz input clock in ov8865
>   media: i2c: Add .get_selection() support to ov8865
>   media: i2c: Switch control to V4L2_CID_ANALOGUE_GAIN
>   media: i2c: Add vblank control to ov8865
>   media: i2c: Add hblank control to ov8865
>   media: i2c: Update HTS values in ov8865
>   media: i2c: cap exposure at height + vblank in ov8865
>   media: i2c: Add controls from fwnode to ov8865
>   media: i2c: Switch exposure control unit to lines
>   media: i2c: Use dev_err_probe() in ov8865
>   media: i2c: Fix max gain in ov8865
>   media: ipu3-cio2: Add INT347A to cio2-bridge
> 
> Hans de Goede (1):
>   media: i2c: ov8865: Fix lockdep error
> 
>  drivers/media/i2c/ov8865.c                 | 466 +++++++++++++++------
>  drivers/media/pci/intel/ipu3/cio2-bridge.c |   2 +
>  2 files changed, 334 insertions(+), 134 deletions(-)
>