[net,0/9] tls: splice_read fixes

Message

Jakub Kicinski Nov. 24, 2021, 11:25 p.m. UTC

As I work my way to unlocked and zero-copy TLS Rx the obvious bugs
in the splice_read implementation get harder and harder to ignore.
This is to say the fixes here are discovered by code inspection,
I'm not aware of anyone actually using splice_read.

Jakub Kicinski (9):
  selftests: tls: add helper for creating sock pairs
  selftests: tls: factor out cmsg send/receive
  selftests: tls: add tests for handling of bad records
  tls: splice_read: fix record type check
  selftests: tls: test splicing cmsgs
  tls: splice_read: fix accessing pre-processed records
  selftests: tls: test splicing decrypted records
  tls: fix replacing proto_ops
  selftests: tls: test for correct proto_ops

 net/tls/tls_main.c                |  47 ++-
 net/tls/tls_sw.c                  |  40 ++-
 tools/testing/selftests/net/tls.c | 521 ++++++++++++++++++++++--------
 3 files changed, 456 insertions(+), 152 deletions(-)

Comments

[e-mail] Nov. 26, 2021, 3:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <[e-mail]>:

On Wed, 24 Nov 2021 15:25:48 -0800 you wrote:
> As I work my way to unlocked and zero-copy TLS Rx the obvious bugs
> in the splice_read implementation get harder and harder to ignore.
> This is to say the fixes here are discovered by code inspection,
> I'm not aware of anyone actually using splice_read.
> 
> Jakub Kicinski (9):
>   selftests: tls: add helper for creating sock pairs
>   selftests: tls: factor out cmsg send/receive
>   selftests: tls: add tests for handling of bad records
>   tls: splice_read: fix record type check
>   selftests: tls: test splicing cmsgs
>   tls: splice_read: fix accessing pre-processed records
>   selftests: tls: test splicing decrypted records
>   tls: fix replacing proto_ops
>   selftests: tls: test for correct proto_ops
> 
> [...]

Here is the summary with links:
  - [net,1/9] selftests: tls: add helper for creating sock pairs
    https://git.kernel.org/netdev/net/c/a125f91fe783
  - [net,2/9] selftests: tls: factor out cmsg send/receive
    https://git.kernel.org/netdev/net/c/31180adb0bed
  - [net,3/9] selftests: tls: add tests for handling of bad records
    https://git.kernel.org/netdev/net/c/ef0fc0b3cc2b
  - [net,4/9] tls: splice_read: fix record type check
    https://git.kernel.org/netdev/net/c/520493f66f68
  - [net,5/9] selftests: tls: test splicing cmsgs
    https://git.kernel.org/netdev/net/c/d87d67fd61ef
  - [net,6/9] tls: splice_read: fix accessing pre-processed records
    https://git.kernel.org/netdev/net/c/e062fe99cccd
  - [net,7/9] selftests: tls: test splicing decrypted records
    https://git.kernel.org/netdev/net/c/274af0f9e279
  - [net,8/9] tls: fix replacing proto_ops
    https://git.kernel.org/netdev/net/c/f3911f73f51d
  - [net,9/9] selftests: tls: test for correct proto_ops
    https://git.kernel.org/netdev/net/c/f884a3426291

You are awesome, thank you!