diff mbox series

[5/9] riscv: dts: microchip: mpfs: Fix PLIC node

Message ID 20211125153131.163533-6-geert@linux-m68k.org (mailing list archive)
State New, archived
Headers show
Series riscv: dts: Miscellaneous fixes | expand

Commit Message

Geert Uytterhoeven Nov. 25, 2021, 3:31 p.m. UTC
Fix the device node for the Platform-Level Interrupt Controller (PLIC):
  - Add missing "#address-cells" property,
  - Sort properties according to DT bindings.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Nov. 26, 2021, 9:49 a.m. UTC | #1
On 25/11/2021 16:31, Geert Uytterhoeven wrote:
> Fix the device node for the Platform-Level Interrupt Controller (PLIC):
>   - Add missing "#address-cells" property,
>   - Sort properties according to DT bindings.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

And similar for fu540-c000.dtsi?

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof
Conor Dooley Nov. 26, 2021, 11:49 a.m. UTC | #2
On 25/11/2021 15:31, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Fix the device node for the Platform-Level Interrupt Controller (PLIC):
>    - Add missing "#address-cells" property,
>    - Sort properties according to DT bindings.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>   arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>


> 
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index d91226bfa586cda7..c71d2d682fc0a0e7 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -168,16 +168,17 @@ clint@2000000 {
>                  };
> 
>                  plic: interrupt-controller@c000000 {
> -                       #interrupt-cells = <1>;
>                          compatible = "sifive,fu540-c000-plic", "sifive,plic-1.0.0";
>                          reg = <0x0 0xc000000 0x0 0x4000000>;
> -                       riscv,ndev = <186>;
> +                       #address-cells = <0>;
> +                       #interrupt-cells = <1>;
>                          interrupt-controller;
>                          interrupts-extended = <&cpu0_intc 11>,
>                                                <&cpu1_intc 11>, <&cpu1_intc 9>,
>                                                <&cpu2_intc 11>, <&cpu2_intc 9>,
>                                                <&cpu3_intc 11>, <&cpu3_intc 9>,
>                                                <&cpu4_intc 11>, <&cpu4_intc 9>;
> +                       riscv,ndev = <186>;
>                  };
> 
>                  dma@3000000 {
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
index d91226bfa586cda7..c71d2d682fc0a0e7 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
@@ -168,16 +168,17 @@  clint@2000000 {
 		};
 
 		plic: interrupt-controller@c000000 {
-			#interrupt-cells = <1>;
 			compatible = "sifive,fu540-c000-plic", "sifive,plic-1.0.0";
 			reg = <0x0 0xc000000 0x0 0x4000000>;
-			riscv,ndev = <186>;
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
 			interrupt-controller;
 			interrupts-extended = <&cpu0_intc 11>,
 					      <&cpu1_intc 11>, <&cpu1_intc 9>,
 					      <&cpu2_intc 11>, <&cpu2_intc 9>,
 					      <&cpu3_intc 11>, <&cpu3_intc 9>,
 					      <&cpu4_intc 11>, <&cpu4_intc 9>;
+			riscv,ndev = <186>;
 		};
 
 		dma@3000000 {