| Message ID | 20211125153131.163533-4-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: dts: Miscellaneous fixes | expand |
On 25/11/2021 16:31, Geert Uytterhoeven wrote: > It does not make sense to have an (empty) chosen node in an SoC-specific > .dtsi, as chosen is meant for system-specific configuration. > It is already provided in microchip-mpfs-icicle-kit.dts anyway. > > Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > index c9f6d205d2ba1a5e..794da883acb19256 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > @@ -9,9 +9,6 @@ / { > model = "Microchip PolarFire SoC"; > compatible = "microchip,mpfs"; > > - chosen { > - }; > - > cpus { > #address-cells = <1>; > #size-cells = <0>; > Maybe bootloader expects it? E.g. it looks for node and fills it and would fail if the node is missing? Best regards, Krzysztof
Hi Krzysztof, On Fri, Nov 26, 2021 at 10:53 AM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > On 25/11/2021 16:31, Geert Uytterhoeven wrote: > > It does not make sense to have an (empty) chosen node in an SoC-specific > > .dtsi, as chosen is meant for system-specific configuration. > > It is already provided in microchip-mpfs-icicle-kit.dts anyway. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board") > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > --- > > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > index c9f6d205d2ba1a5e..794da883acb19256 100644 > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > @@ -9,9 +9,6 @@ / { > > model = "Microchip PolarFire SoC"; > > compatible = "microchip,mpfs"; > > > > - chosen { > > - }; > > - > > cpus { > > #address-cells = <1>; > > #size-cells = <0>; > > > > Maybe bootloader expects it? E.g. it looks for node and fills it and > would fail if the node is missing? Already present in board DTS. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 25/11/2021 15:31, Geert Uytterhoeven wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > It does not make sense to have an (empty) chosen node in an SoC-specific > .dtsi, as chosen is meant for system-specific configuration. > It is already provided in microchip-mpfs-icicle-kit.dts anyway. > > Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi index c9f6d205d2ba1a5e..794da883acb19256 100644 --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi @@ -9,9 +9,6 @@ / { model = "Microchip PolarFire SoC"; compatible = "microchip,mpfs"; - chosen { - }; - cpus { #address-cells = <1>; #size-cells = <0>;
It does not make sense to have an (empty) chosen node in an SoC-specific .dtsi, as chosen is meant for system-specific configuration. It is already provided in microchip-mpfs-icicle-kit.dts anyway. Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 3 --- 1 file changed, 3 deletions(-)