diff mbox series

[v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

Message ID 20211125215310.62371-1-dominikkobinski314@gmail.com (mailing list archive)
State Not Applicable
Headers show
Series Add pm8226 SPMI regulators | expand

Commit Message

Dominik Kobinski Nov. 25, 2021, 9:53 p.m. UTC 
Add support for pm8226 SPMI GPIOs. The PMIC features
8 GPIOs, with no holes inbetween.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Nov. 26, 2021, 12:49 a.m. UTC | #1 
On Thu, Nov 25, 2021 at 10:53 PM Dominik Kobinski
<dominikkobinski314@gmail.com> wrote:

> Add support for pm8226 SPMI GPIOs. The PMIC features
> 8 GPIOs, with no holes inbetween.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>

I applied this to the pinctrl tree.

Is there anything else I should be applying?

Yours,
Linus Walleij
Dominik Kobinski Nov. 26, 2021, 4:36 p.m. UTC | #2 
From: Dominik Kobinski <dkobinski314@gmail.com>

Thank you for applying the patch. I believe the second one in this series (https://patchwork.kernel.org/project/linux-arm-msm/patch/20211125215626.62447-1-dominikkobinski314@gmail.com/) should be also applied to the pinctrl tree.

Regards,
Dominik Kobinski
Linus Walleij Nov. 27, 2021, 1:37 a.m. UTC | #3 
On Fri, Nov 26, 2021 at 5:37 PM Dominik Kobinski
<dominikkobinski314@gmail.com> wrote:

> From: Dominik Kobinski <dkobinski314@gmail.com>
>
> Thank you for applying the patch. I believe the second one in this series (https://patchwork.kernel.org/project/linux-arm-msm/patch/20211125215626.62447-1-dominikkobinski314@gmail.com/) should be also applied to the pinctrl tree.

Looks like the regulator tree should take this one?
It is a regulator binding...

Yours,
Linus Walleij
Linus Walleij Nov. 27, 2021, 1:42 a.m. UTC | #4 
On Sat, Nov 27, 2021 at 2:37 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Fri, Nov 26, 2021 at 5:37 PM Dominik Kobinski
> <dominikkobinski314@gmail.com> wrote:
>
> > From: Dominik Kobinski <dkobinski314@gmail.com>
> >
> > Thank you for applying the patch. I believe the second one in this series (https://patchwork.kernel.org/project/linux-arm-msm/patch/20211125215626.62447-1-dominikkobinski314@gmail.com/) should be also applied to the pinctrl tree.
>
> Looks like the regulator tree should take this one?
> It is a regulator binding...

Oh no the one on the link, right :/
I have already applied that one?

Yours,
Linus Walleij
Matti Lehtimäki July 8, 2022, 7:43 p.m. UTC | #5 
On 26.11.2021 2.49, Linus Walleij wrote:
> On Thu, Nov 25, 2021 at 10:53 PM Dominik Kobinski
> <dominikkobinski314@gmail.com> wrote:
> 
>> Add support for pm8226 SPMI GPIOs. The PMIC features
>> 8 GPIOs, with no holes inbetween.
>>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
>> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
> 
> I applied this to the pinctrl tree.
> 
> Is there anything else I should be applying?
> 
> Yours,
> Linus Walleij

I noticed that this patch was never applied into kernel while the other 
patches such as the device tree documentation were applied. Maybe it was 
missed accidentally? I checked also the pinctrl tree and didn't find the 
commit there either in the branches for the upcoming releases.

-Matti
Linus Walleij July 11, 2022, 1:27 p.m. UTC | #6 
On Fri, Jul 8, 2022 at 9:43 PM Matti Lehtimäki
<matti.lehtimaki@gmail.com> wrote:
>
> On 26.11.2021 2.49, Linus Walleij wrote:
> > On Thu, Nov 25, 2021 at 10:53 PM Dominik Kobinski
> > <dominikkobinski314@gmail.com> wrote:
> >
> >> Add support for pm8226 SPMI GPIOs. The PMIC features
> >> 8 GPIOs, with no holes inbetween.
> >>
> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> >> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
> >
> > I applied this to the pinctrl tree.
> >
> > Is there anything else I should be applying?
> >
> > Yours,
> > Linus Walleij
>
> I noticed that this patch was never applied into kernel while the other
> patches such as the device tree documentation were applied. Maybe it was
> missed accidentally? I checked also the pinctrl tree and didn't find the
> commit there either in the branches for the upcoming releases.

Weird I applied it now.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 5283d5e9e8bc..0f0102f38cbb 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1159,6 +1159,7 @@  static const struct of_device_id pmic_gpio_of_match[] = {
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pmc8180c-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm8226-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },