| Message ID | 20211117143347.314294-2-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/rockchip: RK356x VOP2 support | expand |
Hi, Am Mittwoch, 17. November 2021, 15:33:36 CET schrieb Sascha Hauer: > From: Benjamin Gaignard <benjamin.gaignard@collabora.com> > > Define a new compatible for rk3568 HDMI. > This version of HDMI hardware block needs two new clocks hclk_vio and hclk > to provide phy reference clocks. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Link: https://lore.kernel.org/r/20210707120323.401785-2-benjamin.gaignard@collabora.com > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index da3b889ad8fcd..53fa42479d5b7 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -23,6 +23,7 @@ properties: > - rockchip,rk3288-dw-hdmi > - rockchip,rk3328-dw-hdmi > - rockchip,rk3399-dw-hdmi > + - rockchip,rk3568-dw-hdmi > > reg-io-width: > const: 4 > @@ -49,8 +50,11 @@ properties: > - vpll > - enum: > - grf > + - hclk_vio I don't believe this clock should be here: (1) the rk3568 dts node later in the series doesn't use it at all (2) generally vio-clocks are part of the interconnect where the ip block connects to, so right now we just enable it as critical on all socs and if someone actually models the interconnect (where also the qos [quality of service configs] nodes would play into), it would need to be included there. Heiko > + - vpll > + - enum: > + - hclk > - vpll > - - const: vpll > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle >
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml index da3b889ad8fcd..53fa42479d5b7 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml @@ -23,6 +23,7 @@ properties: - rockchip,rk3288-dw-hdmi - rockchip,rk3328-dw-hdmi - rockchip,rk3399-dw-hdmi + - rockchip,rk3568-dw-hdmi reg-io-width: const: 4 @@ -49,8 +50,11 @@ properties: - vpll - enum: - grf + - hclk_vio + - vpll + - enum: + - hclk - vpll - - const: vpll ddc-i2c-bus: $ref: /schemas/types.yaml#/definitions/phandle